Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable currency service metrics #74

Closed
wants to merge 1 commit into from
Closed

Re-enable currency service metrics #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions gcp-config-values.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@
- set(attributes["exported_project_id"], attributes["project_id"])
- delete_key(attributes, "project_id")

# See https:/open-telemetry/opentelemetry-demo/issues/1330
filter/currency:
metrics:
metric:
- 'IsMatch(name, "(.*)app_currency(.*)")'

exporters:
googlecloud:
log:
Expand All @@ -76,8 +70,8 @@
exporters: [googlecloud]
traces:
processors: [memory_limiter, resourcedetection, resource, batch]
exporters: [googlecloud] #spanmetrics disabled

Check warning on line 73 in gcp-config-values.yml

View workflow job for this annotation

GitHub Actions / yamllint 

73:36 [comments] too few spaces before comment

Check warning on line 73 in gcp-config-values.yml

View workflow job for this annotation

GitHub Actions / yamllint 

73:37 [comments] missing starting space in comment

Check warning on line 73 in gcp-config-values.yml

View workflow job for this annotation

GitHub Actions / yamllint 

73:36 [comments] too few spaces before comment

Check warning on line 73 in gcp-config-values.yml

View workflow job for this annotation

GitHub Actions / yamllint 

73:37 [comments] missing starting space in comment
metrics:
receivers: [otlp] #spanmetrics disabled

Check warning on line 75 in gcp-config-values.yml

View workflow job for this annotation

GitHub Actions / yamllint 

75:29 [comments] too few spaces before comment

Check warning on line 75 in gcp-config-values.yml

View workflow job for this annotation

GitHub Actions / yamllint 

75:30 [comments] missing starting space in comment

Check warning on line 75 in gcp-config-values.yml

View workflow job for this annotation

GitHub Actions / yamllint 

75:29 [comments] too few spaces before comment

Check warning on line 75 in gcp-config-values.yml

View workflow job for this annotation

GitHub Actions / yamllint 

75:30 [comments] missing starting space in comment
processors: [filter/currency, memory_limiter, resourcedetection, transform/collision, resource, batch]
processors: [memory_limiter, resourcedetection, transform/collision, resource, batch]
exporters: [googlemanagedprometheus]
7 changes: 0 additions & 7 deletions kubernetes/opentelemetry-demo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,6 @@ data:
- set(attributes["exported_project_id"], attributes["project_id"])
- delete_key(attributes, "project_id")

# See https:/open-telemetry/opentelemetry-demo/issues/1330
filter/currency:
metrics:
metric:
- 'IsMatch(name, "(.*)app_currency(.*)")'

receivers:
jaeger:
protocols:
Expand Down Expand Up @@ -318,7 +312,6 @@ data:
- k8sattributes
- memory_limiter
- filter/ottl
- filter/currency
- resourcedetection
- transform
- transform/collision
Expand Down
8 changes: 1 addition & 7 deletions src/otelcollector/otelcol-config-extras.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@
- set(attributes["exported_project_id"], attributes["project_id"])
- delete_key(attributes, "project_id")

# See https:/open-telemetry/opentelemetry-demo/issues/1330
filter/currency:
metrics:
metric:
- 'IsMatch(name, "(.*)app_currency(.*)")'

exporters:
googlecloud:
log:
Expand All @@ -72,8 +66,8 @@
exporters: [googlecloud]
traces:
processors: [memory_limiter, resourcedetection, batch]
exporters: [googlecloud] #spanmetrics disabled

Check warning on line 69 in src/otelcollector/otelcol-config-extras.yml

View workflow job for this annotation

GitHub Actions / yamllint 

69:32 [comments] too few spaces before comment

Check warning on line 69 in src/otelcollector/otelcol-config-extras.yml

View workflow job for this annotation

GitHub Actions / yamllint 

69:33 [comments] missing starting space in comment

Check warning on line 69 in src/otelcollector/otelcol-config-extras.yml

View workflow job for this annotation

GitHub Actions / yamllint 

69:32 [comments] too few spaces before comment

Check warning on line 69 in src/otelcollector/otelcol-config-extras.yml

View workflow job for this annotation

GitHub Actions / yamllint 

69:33 [comments] missing starting space in comment
metrics:
receivers: [otlp] #spanmetrics disabled

Check warning on line 71 in src/otelcollector/otelcol-config-extras.yml

View workflow job for this annotation

GitHub Actions / yamllint 

71:25 [comments] too few spaces before comment

Check warning on line 71 in src/otelcollector/otelcol-config-extras.yml

View workflow job for this annotation

GitHub Actions / yamllint 

71:26 [comments] missing starting space in comment

Check warning on line 71 in src/otelcollector/otelcol-config-extras.yml

View workflow job for this annotation

GitHub Actions / yamllint 

71:25 [comments] too few spaces before comment

Check warning on line 71 in src/otelcollector/otelcol-config-extras.yml

View workflow job for this annotation

GitHub Actions / yamllint 

71:26 [comments] missing starting space in comment
processors: [filter/currency, memory_limiter, resourcedetection, transform/collision, batch]
processors: [memory_limiter, resourcedetection, transform/collision, batch]
exporters: [googlemanagedprometheus]
Loading