Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Cloud Run service #118

Merged
merged 4 commits into from
Dec 10, 2020
Merged

Add support for Cloud Run service #118

merged 4 commits into from
Dec 10, 2020

Conversation

yegle
Copy link
Contributor

@yegle yegle commented Nov 17, 2020

Fixes #117

@dashpole dashpole self-assigned this Nov 17, 2020
@yegle
Copy link
Contributor Author

yegle commented Nov 18, 2020

Please hold merging this PR. I think I should get open-telemetry/opentelemetry-go-contrib#455 merged first.

@yegle
Copy link
Contributor Author

yegle commented Dec 10, 2020

I've updated the PR based on the detector added in open-telemetry/opentelemetry-go-contrib#455.

This PR is now ready to review. PTAL.

@yegle yegle changed the title Add support of generic_task metric type. Add support to Cloud Run service Dec 10, 2020
@yegle yegle changed the title Add support to Cloud Run service Add support for Cloud Run service Dec 10, 2020
@yegle yegle mentioned this pull request Dec 10, 2020
Closed
dashpole
dashpole reviewed Dec 10, 2020
View reviewed changes
exporter/metric/constants.go Outdated Show resolved Hide resolved
exporter/metric/constants.go Outdated Show resolved Hide resolved
@yegle
Copy link
Contributor Author

yegle commented Dec 10, 2020

Updated per review comments. PTAL.

dashpole
dashpole approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit d8551be into GoogleCloudPlatform:master Dec 10, 2020
@yegle yegle deleted the support-generic-task-type branch December 10, 2020 23:30
@ptone ptone mentioned this pull request Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

Assignees

@dashpole dashpole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metric: generic_task is not supported.
2 participants
@yegle @dashpole