Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detector for Cloud Run service. #455

Merged
merged 18 commits into from
Dec 10, 2020
Merged

Add detector for Cloud Run service. #455

merged 18 commits into from
Dec 10, 2020

Conversation

yegle
Copy link
Contributor

@yegle yegle commented Nov 17, 2020

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 17, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 18, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@yegle yegle mentioned this pull request Nov 18, 2020
Merged
@yegle
Copy link
Contributor Author

yegle commented Nov 18, 2020

Ping, this one is ready to review.

@Aneurysm9
Copy link
Member

Please add a CHANGELOG.md entry for this addition.

@yegle
Copy link
Contributor Author

yegle commented Nov 18, 2020

Please add a CHANGELOG.md entry for this addition.

Done. Thanks for the review!

XSAM
XSAM reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some tests for this detector?

@yegle
Copy link
Contributor Author

yegle commented Nov 19, 2020

Should we add some tests for this detector?

Unit test added.

MrAlias
MrAlias reviewed Nov 19, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
detectors/gcp/cloud-run.go Outdated Show resolved Hide resolved
detectors/gcp/cloud-run.go Outdated Show resolved Hide resolved
detectors/gcp/cloud-run.go Outdated Show resolved Hide resolved
detectors/gcp/cloud-run_test.go Outdated Show resolved Hide resolved
detectors/gcp/cloud-run.go Show resolved Hide resolved
detectors/gcp/cloud-run_test.go Show resolved Hide resolved
@ptone ptone mentioned this pull request Nov 19, 2020
Closed
jmacd
jmacd approved these changes Nov 24, 2020
View reviewed changes
detectors/gcp/cloud-run.go Outdated Show resolved Hide resolved
@yegle
Copy link
Contributor Author

yegle commented Nov 24, 2020

I added a note to suggest not relying on the value of service.namespace just yet, in case we want to change it in the future.

@yegle
Copy link
Contributor Author

yegle commented Nov 30, 2020

Can I get this PR merged? Thank you!

MrAlias
MrAlias approved these changes Dec 3, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yegle
Copy link
Contributor Author

yegle commented Dec 7, 2020

Merged latest master changes into this branch. PTAL.

dashpole
dashpole reviewed Dec 8, 2020
View reviewed changes
detectors/gcp/cloud-run.go Outdated Show resolved Hide resolved
@yegle yegle requested review from XSAM and MrAlias December 9, 2020 17:22
@yegle
Copy link
Contributor Author

yegle commented Dec 10, 2020

Can I get this PR merged? Thank you!

@MrAlias MrAlias merged commit 54c6a6c into open-telemetry:master Dec 10, 2020
@yegle yegle deleted the cloud-run-detector branch December 10, 2020 17:50
@Aneurysm9 Aneurysm9 mentioned this pull request Dec 11, 2020
Merged
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@amrmahdi @krnowak @rghetia
Add AlwaysParentSample sampler (#455)
6051c81 
* Add AlwaysParentSample

* Update sampler doc

Co-Authored-By: Krzesimir Nowak <[email protected]>

* Address PR comments

Co-authored-by: Krzesimir Nowak <[email protected]>
Co-authored-by: Rahul Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@dashpole dashpole dashpole approved these changes

@jmacd jmacd jmacd approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@XSAM XSAM Awaiting requested review from XSAM

@MrAlias MrAlias Awaiting requested review from MrAlias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yegle @Aneurysm9 @dashpole @jmacd @MrAlias @XSAM