Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate useOnlyProjectCache from plugin configuration and only set via system property #1308

Closed
TadCordle opened this issue Dec 5, 2018 · 1 comment · Fixed by #1324
Closed

Deprecate useOnlyProjectCache from plugin configuration and only set via system property #1308

TadCordle opened this issue Dec 5, 2018 · 1 comment · Fixed by #1324
Assignees
@TadCordle
Milestone
v1.0.0

Comments

@TadCordle
Copy link
Contributor

TadCordle commented Dec 5, 2018 •
edited
Loading

Original comment

We might want to consider deprecating useOnlyProjectCache to remove that from the plugin configuration and have that settable via the new system property. It didn't make sense to define the cache location via the plugin configuration anyways.
@TadCordle TadCordle mentioned this issue Dec 5, 2018
Merged
@chanseokoh
Copy link
Member

I remember our test projects use this configuration, so they should be migrated too.

@coollog coollog added this to the v1.0.0 milestone Dec 5, 2018
@TadCordle TadCordle self-assigned this Dec 7, 2018
@TadCordle TadCordle mentioned this issue Dec 7, 2018
Merged
@TadCordle TadCordle changed the title Consider deprecating useOnlyProjectCache from plugin configuration and only set via system property Deprecate useOnlyProjectCache from plugin configuration and only set via system property Dec 7, 2018
@TadCordle TadCordle mentioned this issue Dec 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TadCordle TadCordle

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Remove useOnlyProjectCache in favor of system property GoogleContainerTools/jib
3 participants
@TadCordle @coollog @chanseokoh