Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system properties for setting cache directories #1306

Merged
merged 5 commits into from
Dec 7, 2018
Merged

Add system properties for setting cache directories #1306

merged 5 commits into from
Dec 7, 2018

Conversation

TadCordle
Copy link
Contributor

@TadCordle TadCordle commented Dec 5, 2018 •
edited
Loading

Fixes #1238.

Adds two system properties for setting cache directories:

  • jib.baseImageCache
  • jib.applicationCache

@coollog
Copy link
Contributor

coollog commented Dec 5, 2018

We might want to consider deprecating useOnlyProjectCache to remove that from the plugin configuration and have that settable via the new system property. It didn't make sense to define the cache location via the plugin configuration anyways.

@TadCordle TadCordle mentioned this pull request Dec 5, 2018
Closed
@TadCordle
Copy link
Contributor Author

Filed an issue #1308

@TadCordle TadCordle requested a review from a team December 7, 2018 03:16
coollog
coollog approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@coollog coollog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a CHANGELOG for this.

@TadCordle TadCordle merged commit a7377b9 into master Dec 7, 2018
@TadCordle TadCordle deleted the i1238-cache-dir-properties branch December 7, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka left review comments

@coollog coollog coollog approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TadCordle @coollog @loosebazooka @googlebot