Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_runner_matrix: filter incompatible testing formulae #18166

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew test-bot can occasionally spend a long time doing nothing when
testing dependents.1 This is because it takes a long time to work out
that there is nothing to do.

To fix this, let's adjust brew determine-test-runners to pass on only
the list of formulae for which there is work to be done so that
brew test-bot doesn't need to waste time working this out.

TODO: Update some tests.

Footnotes

  1. For example, it spends about 15 minutes doing nothing at https:/Homebrew/homebrew-core/actions/runs/10500178069/job/29133091332?pr=180185

`brew test-bot` can occasionally spend a long time doing nothing when
testing dependents.[^1] This is because it takes a long time to work out
that there is nothing to do.

To fix this, let's adjust `brew determine-test-runners` to pass on only
the list of formulae for which there is work to be done so that
`brew test-bot` doesn't need to waste time working this out.

[^1]: For example, it spends about 15 minutes doing nothing at https:/Homebrew/homebrew-core/actions/runs/10500178069/job/29133091332?pr=180185
@carlocab
Copy link
Member Author

For ease of review: there shouldn't be any changes in logic here. I'm just keeping data that we used to throw away and then adding some of it to the matrix JSON.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense once 🟢! Merge at the beginning of your day so you can be around to 🔨 any regressions.

@carlocab carlocab marked this pull request as ready for review August 27, 2024 14:53
We should only activate a runner when there are deleted formulae if it
isn't a dependent matrix.
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Aug 28, 2024
@carlocab carlocab merged commit 62d187d into master Aug 28, 2024
27 checks passed
@carlocab carlocab deleted the runner-spec-formulae branch August 28, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants