Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_runner_matrix: filter incompatible testing formulae #18166

Merged
merged 2 commits into from
Aug 28, 2024

Commits on Aug 26, 2024

  1. github_runner_matrix: filter incompatible testing formulae

    `brew test-bot` can occasionally spend a long time doing nothing when
    testing dependents.[^1] This is because it takes a long time to work out
    that there is nothing to do.
    
    To fix this, let's adjust `brew determine-test-runners` to pass on only
    the list of formulae for which there is work to be done so that
    `brew test-bot` doesn't need to waste time working this out.
    
    [^1]: For example, it spends about 15 minutes doing nothing at https:/Homebrew/homebrew-core/actions/runs/10500178069/job/29133091332?pr=180185
    carlocab committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3588f1b View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Fix logic error in active_runner?

    We should only activate a runner when there are deleted formulae if it
    isn't a dependent matrix.
    carlocab committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c61492a View commit details
    Browse the repository at this point in the history