Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypesto.ensemble.ensemble.EnsemblePrediction.compute_chi2 incorrectly assumes all edatas have equal number of timepoints #1296

Open
dweindl opened this issue Jan 25, 2024 · 0 comments
Labels
bug Something isn't working ensembles Related to parameter ensembles

Comments

@dweindl
Copy link
Member

dweindl commented Jan 25, 2024

pypesto.ensemble.ensemble.EnsemblePrediction.compute_chi2 incorrectly assumes all amici_objective.edatas have equal number of timepoints, here:

for i_cond in range(n_conditions):
# get measurements and put into right form
y_meas = amici_objective.edatas[i_cond].getObservedData()
y_meas = np.array(y_meas)
# bring into shape (n_t,n_y)
y_meas = y_meas.reshape(
amici_objective.edatas[0].nt(),
amici_objective.edatas[0].nytrue(),
)

This isn't necessarily correct.

@dweindl dweindl added bug Something isn't working ensembles Related to parameter ensembles labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ensembles Related to parameter ensembles
Projects
None yet
Development

No branches or pull requests

1 participant