Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request/431 file upload page missing features #431

Open
3 of 12 tasks
ErykKul opened this issue Jul 10, 2024 · 1 comment
Open
3 of 12 tasks

Feature Request/431 file upload page missing features #431

ErykKul opened this issue Jul 10, 2024 · 1 comment
Labels
enhancement New feature or request GREI Re-arch GREI re-architecture-related integration Tasks involving the connection and interaction of UI features with the Dataverse API SPA: File Upload Page

Comments

@ErykKul
Copy link
Contributor

ErykKul commented Jul 10, 2024

Overview of the Feature Request
This issue summarizes the remaining work needed to have a fully featured file upload functionality in the new SPA UI.
Follow-up to the PR #418:

  • Race Condition in UploadDatasetFiles unit test #481
  • use the new SelectMultiple component for tag selection
  • implement handling of the duplicate files having either an identical content or label+name
  • extend the interface of the add uploaded files call in the js-dataverse library to accept more parameters, like tags, description, etc., and make it support adding multiple files at once, i.s.o. adding files one-by-one (addUploadedFilesToDataset call), see also https://guides.dataverse.org/en/latest/developers/s3-direct-upload-api.html#direct-add-to-dataset-api. When ready, the implementation of FileJSDataverseRepository.ts addUploadedFile method can be refactored to no longer mock a file, that is not needed here, but to use a proper interface with description, restricted boolean, tags, etc.
  • implement turning off tagging option for the file upload use case in DV-JS client
  • implement new use case needed for installations not supporting S3 tagging, but also useful for other installations: cleanup storage of a dataset
  • refactor scss of src/sections/upload-dataset-files/FileUploader.module.scss to no longer contain the !important addition.
  • improve state handling where it can be simplified in some way
  • add real e2e test at least for this cases:
    • Upload a single file
    • Upload multiple files
    • Upload multiple files and cancel one.
    • And after each test navigate to the Dataset that the files were uploaded and check they exists in the Files Table
  • display: contents causes an element's children to appear as if they were direct children of the element's parent, ignoring the element itself. This can be useful when a wrapper element should be ignored when using CSS grid or similar layout techniques. It's a bit fragile css hack and we should use a table here perhaps and not a Card to render the list of uploaded files.
  • document differences with the JSF file upload
  • implement dvwebloader using file upload page Feature Request/Idea: reusing file upload page as dvwebloader #468

What kind of user is the feature intended for?
(Example users roles: API User, Curator, Depositor, Guest, Superuser, Sysadmin)
Depositor

What inspired the request?
Uploading files feature.

What existing behavior do you want changed?

Any brand-new behavior do you want to add to Dataverse?
Uploading files feature.

Any open or closed issues related to this feature request?
#417

@ErykKul ErykKul changed the title Feature Request/Idea: Feature Request/431 file upload page missing features Jul 10, 2024
@ErykKul ErykKul added enhancement New feature or request MVP Milestone 2 MVP Milestone 2: Add a Dataset integration Tasks involving the connection and interaction of UI features with the Dataverse API SPA: File Upload Page Size: 50 A percentage of a sprint. 35 hours. GREI Re-arch GREI re-architecture-related and removed Size: 50 A percentage of a sprint. 35 hours. MVP Milestone 2 MVP Milestone 2: Add a Dataset labels Jul 10, 2024
@ErykKul
Copy link
Contributor Author

ErykKul commented Aug 23, 2024

Integration tests are implemented in PR #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GREI Re-arch GREI re-architecture-related integration Tasks involving the connection and interaction of UI features with the Dataverse API SPA: File Upload Page
Projects
Status: No status
Development

No branches or pull requests

1 participant