Feature/417 File upload integration

[ErykKul]

What this PR does / why we need it:

File upload works now, integration test is added

Which issue(s) this PR closes:

• Closes Integrate file upload page with js-dataverse use cases #417

Special notes for your reviewer:

Suggestions on how to test this:

Upload some file to a dataset.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No interface changes.

Is there a release notes update needed for this change?:

Something like "added files upload feature"

Additional documentation:

[coveralls]

coverage: 97.42% (-0.05%) from 97.466%
when pulling f1ff52d on feature/417-upload-integration
into c71e287 on develop.

[g-saracca]

Hi @ErykKul great work! just some comments.
Also one thing I noticed in the UI, the checkboxes to select an uploaded file from the UploadedFiles list are not being checked/unchecked on the first click, somehow they only are checked/unchecked on the second click.

[ErykKul]

I have added the gap. I think that the header warning is something that the js-client sets. I can look at it, as well as improving the progress updates (I think that one would also require changes at the js-client).

[GPortas]

@ErykKul Thanks for addressing the changes. I have retested the feature for .java files and it works great.

I think this is ready to be merged, and open a separate issue in js-dataverse to review the header warning and progress updates. @g-saracca

[ErykKul]

I tried fixing the header and progress bar issue: IQSS/dataverse-client-javascript#187
I will test it locally now. I will let you know if it worked. It is fine for me if it will be a separate issue.

[ErykKul]

I think it fixed it, I will add it to this PR, we can revert it if needed.

[ErykKul]

The progress bar moves nicely and there are no errors in the log. However, multipart upload does not work as it should, it looks like it "resets" with every part (starts from 0 and never reaches 100%). I will try fixing it, it should be easy to do (I think that my assumption on the index and part size were incorrect, or I messed up the formula).

[ErykKul]

I think that it was a correct behavior: resetting was due to the upload failing, from the log it looks like uploading first part always failed with some retries (maybe the file is too large for the test-bucket)? Anyway, it is the best I could do for now. I updated the dependency again, after a small fix on the multipart progress updates. I will stop committing now, such that the review and QA can continue. Thanks @g-saracca and @GPortas

[g-saracca]

@ErykKul you made changes to the file upload use case on the js-dataverse repo?

[g-saracca]

If that is the case we should first I think , review and approve the JS-dataverse PR 👍🏼

[ErykKul]

Yes, it was a small change in the js-dataverse. It is not urgent, I think it is most important to get it right, so I think it is a good idea to take a look at my change at the js-dataverse first: PR 187

[GPortas]

This works great now. I just merged the js-dataverse PR and tested it on this branch. All issues are solved.

testjsdv.mov

[g-saracca]

Great job @ErykKul ! approving again and merging!