-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BM3D(sparse 3D transform-domain collaborative filtering) denoising algorithm. #21
Conversation
Thanks! Any reason to make it a conditional dependency? (FYI, usually, we use https:/JuliaPackaging/Requires.jl for conditional codes) Can you also add a demo similar to https:/JuliaImages/ImageNoise.jl/blob/master/docs/examples/reduce_noise/nonlocal.jl? Also, it would be great to also have a regression test to make sure future improvement don't make it worse, like how ImageNoise.jl/test/ReduceNoise/NonlocalMean.jl Lines 62 to 72 in 3381164
|
Could you tell me what the role of conditional dependency is? |
Generally, we should use hard dependency and let Pkg do everything for us, because it allows 1) less code management, and 2) precompilation. In some typical cases like There're some discussions in JuliaLang/Pkg.jl#977 to allow Pkg do conditional dependency management. In our case, I think we can just use the hard dependency as if |
I don't think everyone will use this function. For example, if I just want to use |
I realize that this package is a bit old and broken, so I've made a PR in #22 to upgrade it. (Just merged)
Okay, in this case, we can use Requires.jl for this purpose. We can write # in src/ReduceNoise/ReduceNoise.jl
using Requires
function __init__()
@require BM3DDenoise="95fb3b36-088a-43fb-bb1b-b1f34fadbd7d" include("BM3DDenoise.jl")
end |
Oh sorry! Forget about the Requires stuff. I didn't get your ideas correctly. This is a nice idea and I think we should propose to other packages as well. |
Let's just add some basic demo and basic tests. And add BM3DDenoise to Project.toml |
OK, I will. |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 93.61% 94.23% +0.61%
==========================================
Files 5 6 +1
Lines 94 104 +10
==========================================
+ Hits 88 98 +10
Misses 6 6
Continue to review full report at Codecov.
|
democards grammar. Co-authored-by: Johnny Chen <[email protected]>
@Longhao-Chen thank you for adding this! |
No description provided.