Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to recent dependency versions #22

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Aug 4, 2021

This package was written back in 2018 when I was doing my GSoC project as an experimental playground. There are a lot of upgrades upstream since then, and I've become more familiar with the JuliaImages ecosystem. This PR is a general upgrade to both the source code and the documentation:

  • upgrade to latest dependency versions
  • remove unnecessary dependencies from Project.toml
  • update demos in documentation

- ImageFiltering are removed as it is not really necessary for NLMean
- ImageCore 0.9 is a big change that it loads ColorVectorSpace unconditionally,
  we direct upgrade to it without any backward compatibility
- also, apply a version patch to ColorVectorSpace for `abs`/`abs2`
- for MappdedArrays, ColorVectorSpace and OffsetArrays, we use the version
  allowed by ImageCore
- update Distributions to v0.25
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #22 (2dae3c0) into master (0abf0ea) will decrease coverage by 2.19%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   95.74%   93.54%   -2.20%     
==========================================
  Files           8        5       -3     
  Lines          94       93       -1     
==========================================
- Hits           90       87       -3     
- Misses          4        6       +2     
Impacted Files Coverage Δ
src/ApplyNoise/ApplyNoise.jl 100.00% <ø> (ø)
src/ReduceNoise/compat.jl 42.85% <50.00%> (+9.52%) ⬆️
src/ReduceNoise/NonlocalMean.jl 100.00% <100.00%> (ø)
src/NoiseAPI/utils.jl 100.00% <0.00%> (ø)
src/NoiseAPI/NoiseAPI.jl
src/ImageNoise.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3381164...2dae3c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant