Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Create status checks #86

Closed
12 tasks done
CalvinWilkinson opened this issue May 4, 2023 · 0 comments · Fixed by #87
Closed
12 tasks done

🚧Create status checks #86

CalvinWilkinson opened this issue May 4, 2023 · 0 comments · Fixed by #87
Assignees
Labels
cicd CI/CD and workflow related work only high-priority High Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented May 4, 2023

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Create a new status check that will execute for PRs that merge from a feature branch to a master branch.

Things to implement:

  1. The name of the status check file will be version-notes-status-check.yml.
  2. First check will check if a tag exists with the same name as the current version in the csproj file. If it does, it will fail.
  3. If the first check (step) passes, it will then check if the release notes for that version already exist, and if not, it will fail.
  4. The status check should only run when changes are made for .cs and .csproj files.
  5. Set up the triggers for the paths mentioned in step 4 as well as for the master branch. Refer to the setup below:
on:
  pull_request:
    branches:
      - master
    paths:
      - "**.cs"
      - "**.csproj"

Acceptance Criteria

  • Status check workflow created
    • Checks if the version in the csproj already exists as a tag
    • The workflow named as version-notes-status-check.yml
    • The workflow must only run when changes are made for .cs and .csproj files
    • Triggers setup for pull requests merging into master.

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if applicable).
  • Issue linked to the correct milestone (if applicable).
  • Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview cicd CI/CD and workflow related work only labels May 4, 2023
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.2 milestone May 4, 2023
kselena added a commit that referenced this issue May 4, 2023
@kselena kselena linked a pull request May 4, 2023 that will close this issue
11 tasks
CalvinWilkinson added a commit that referenced this issue May 4, 2023
* Start work for issue #86

* ci: create status check for version and release note checks

* force status checks

---------

Co-authored-by: Calvin Wilkinson <[email protected]>
@CalvinWilkinson CalvinWilkinson removed this from the v1.0.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd CI/CD and workflow related work only high-priority High Priority preview Done while in preview
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants