Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Create status checks #87

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

kselena
Copy link
Member

@kselena kselena commented May 4, 2023

Feature Pull Request

📋Review Checklist📋

  • The head(source) branch for this pull request is a feature branch, with the correct naming syntax, in the following example:

    • A head(source) branch is the branch being merged into a target branch.

      Example
      Syntax: feature/<issue-num>-<description>
      Example: feature/123-my-feature
  • The head(source) branch for this pull request is created from a development branch with the name develop.

  • The base(target) branch for this pull request is a development branch with the name develop.

    • A base(target) branch is the branch that the head(source) branch is merging into.

💡For more information on branching, refer to the project's branching documentation.

  • The associated issue exists and is linked to this pull request.

    • One issue per pull request.
  • The pull request title matches the title of the associated issue.

  • The labels attached to this PR match the labels attached to the associated issue.

  • The assigned project matches the project of the associated issue.

  • The assigned milestone matches the milestone of the associated issue.

  • My code follows the coding style of this project.

    • The style is enforced by the .editorconfig files in the project and displayed as warnings. If there is an edge case, reach out, and let's discuss it.
  • I have manually tested my code changes to the best of my ability.

  • All tests passed locally.

    • This is required because unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
    • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
    • Status checks run for this pull request when merging into the develop branch. These status checks run every time a change is pushed to the pull request. These checks validate version syntax, tagging, builds, unit tests, and more.

@kselena kselena self-assigned this May 4, 2023
@kselena kselena added high-priority High Priority preview Done while in preview cicd CI/CD and workflow related work only labels May 4, 2023
@kselena kselena added this to the v1.0.0-preview.2 milestone May 4, 2023
@kselena kselena linked an issue May 4, 2023 that may be closed by this pull request
12 tasks
@kselena kselena force-pushed the feature/86-create-status-checks branch from afbf37c to 89c3cd1 Compare May 4, 2023 12:27
@CalvinWilkinson CalvinWilkinson force-pushed the feature/86-create-status-checks branch 2 times, most recently from 6ffa597 to e240f09 Compare May 4, 2023 12:40
@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review May 4, 2023 12:41
@CalvinWilkinson CalvinWilkinson force-pushed the feature/86-create-status-checks branch from 4afce3f to 01685dd Compare May 4, 2023 14:09
@CalvinWilkinson CalvinWilkinson merged commit 98174a1 into master May 4, 2023
@CalvinWilkinson CalvinWilkinson deleted the feature/86-create-status-checks branch May 4, 2023 15:17
@CalvinWilkinson CalvinWilkinson removed this from the v1.0.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd CI/CD and workflow related work only high-priority High Priority preview Done while in preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚧Create status checks
3 participants