-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update KIC troubleshooting for 2.9 and add GWAPI port note #5196
Conversation
Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation.
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
https://deploy-preview-5196--kongdocs.netlify.app/kubernetes-ingress-controller/latest/troubleshooting/#identifying-and-fixing-invalid-configuration formatting looks okay. I don't love my presentation of brief "how Event lifecycle works" (there apparently isn't a good description of this upstream? I am only finding unofficial blogs, unfortunately), but eh. Is there a way to tell Vale to ignore anything within a codeblock? The "typos" it's catching in the examples are all proper case for those Kubernetes resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes! I left a few comments, mostly about if we needed to add conditional rendering to specific examples for 2.9.x vs. 2.8.x. Let me know if you have any questions!
app/_src/kubernetes-ingress-controller/deployment/admission-webhook.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/using-gateway-api.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/using-gateway-api.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/using-gateway-api.md
Outdated
Show resolved
Hide resolved
{:.note} | ||
> {{site.base_gateway}} 2.8 only emits `KongConfigurationTranslationFailed` | ||
> Events. `KongConfigurationApplyFailed` Events were added in 2.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we conditionalize the examples I referenced earlier, I don't think this note would be needed.
namespace: default | ||
resourceVersion: "861" | ||
uid: ab78a0fa-ebe7-4d86-a465-a4e7d636ccff | ||
reason: KongConfigurationApplyFailed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also have an example for 2.8.x since this is specific to 2.9.x?
Co-authored-by: Diana <[email protected]>
@rainest WRT your other comment on here, I think the "Identify and fix an invalid configuration" section looks good to me! I thought the content flowed well and made sense. For the Vale errors, I can fix those on your branch in just a minute. I just have to add those words to the dictionary file (I don't believe Vale skips over anything in code). |
Signed-off-by: Diana <[email protected]>
@cloudjumpercat re all the 2.9/2.8 stuff this is kind of a weird one. For end users, the functionality is virtually identical: if KIC can't process a resource for some reason, it generates an Event, and that Event's message indicates which field is broken. The distinction between translation and apply failures is largely an internal technical one that matters to us, the application developers, because KIC handles them a bit differently internally. For end users, the action you need to take doesn't change (you always need to correct whatever issue the Event message describes). Apply errors (which only 2.9+ raises) are, however, the ones we expect users to encounter more often, because translation errors we make a best-effort fix--they alert you to something we can't do as requested, but that doesn't break everything. Apply errors, by contrast, do break everything: KIC literally cannot make updates until you fix them. Given that the user workflow is basically the same for either, I wanted to showcase the more severe problem in examples even though 2.8 doesn't support it. We expect most 2.8 users will just go to 2.9, as 2.9 doesn't have breaking changes, mostly just new functionality you can ignore if it's not of interest to you and bugfixes. On that basis, I wanted to use a slightly atypical approach without full version gates, because doing that would mean having two basically identical sections with different types of broken resources. I did add a92fefb to hide the note on 2.9 onward and try and clarify a bit, do you think that works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for updating this! I'll hold off on merging until 2.9 is released.
@rainest That makes sense to me! Thanks for explaining that :) |
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]>
* Add 2.9 nav file and 2.9 version to version file Signed-off-by: Diana <[email protected]> * docs: GRPCRoute guide (#5216) docs: GRPCRoute guide added Signed-off-by: Mattia Lavacca <[email protected]> * Update KIC troubleshooting for 2.9 and add GWAPI port note (#5196) * chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]> * KIC 2.9.x update deployment guides - Gateway Discovery (#5231) * feat(kic): add docs about Gateway Discovery --------- Co-authored-by: Grzegorz Burzyński <[email protected]> * chore(kic) extract common docs to includes (#5256) Co-authored-by: Michael Heap <[email protected]> * docs(kic): update kic 2.9 nav (#5253) Signed-off-by: Mattia Lavacca <[email protected]> * doc(kic): update compatibility tables for 2.9 (#5259) * kic: show Gateway Discovery guide entry for versions 2.9+ * chore(kic): fix code block languages * chore(kic): fix incorrect helm.sh link * GatewayAlpha feature-gate added to grpc guide (#5323) kic: update grpcRoute GatewayAlpha FG Signed-off-by: Mattia Lavacca <[email protected]> * Update docs for KIC 2.9.0 (#5360) Synchronize auto-generated KIC API reference Signed-off-by: Kong's Team k8s bot <[email protected]> Co-authored-by: Travis Raines <[email protected]> * chore(kic) update CRD links in nav * chore(kic) generate 2.8 KIC CRD reference (#5361) Synchronize auto-generated KIC API reference Signed-off-by: Kong's Team k8s bot <[email protected]> --------- Signed-off-by: Diana <[email protected]> Signed-off-by: Mattia Lavacca <[email protected]> Signed-off-by: Kong's Team k8s bot <[email protected]> Co-authored-by: Diana <[email protected]> Co-authored-by: Mattia Lavacca <[email protected]> Co-authored-by: Travis Raines <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]> Co-authored-by: Michael Heap <[email protected]> Co-authored-by: Kong's Team k8s bot <[email protected]>
* Add 2.9 nav file and 2.9 version to version file Signed-off-by: Diana <[email protected]> * docs: GRPCRoute guide (Kong#5216) docs: GRPCRoute guide added Signed-off-by: Mattia Lavacca <[email protected]> * Update KIC troubleshooting for 2.9 and add GWAPI port note (Kong#5196) * chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]> * KIC 2.9.x update deployment guides - Gateway Discovery (Kong#5231) * feat(kic): add docs about Gateway Discovery --------- Co-authored-by: Grzegorz Burzyński <[email protected]> * chore(kic) extract common docs to includes (Kong#5256) Co-authored-by: Michael Heap <[email protected]> * docs(kic): update kic 2.9 nav (Kong#5253) Signed-off-by: Mattia Lavacca <[email protected]> * doc(kic): update compatibility tables for 2.9 (Kong#5259) * kic: show Gateway Discovery guide entry for versions 2.9+ * chore(kic): fix code block languages * chore(kic): fix incorrect helm.sh link * GatewayAlpha feature-gate added to grpc guide (Kong#5323) kic: update grpcRoute GatewayAlpha FG Signed-off-by: Mattia Lavacca <[email protected]> * Update docs for KIC 2.9.0 (Kong#5360) Synchronize auto-generated KIC API reference Signed-off-by: Kong's Team k8s bot <[email protected]> Co-authored-by: Travis Raines <[email protected]> * chore(kic) update CRD links in nav * chore(kic) generate 2.8 KIC CRD reference (Kong#5361) Synchronize auto-generated KIC API reference Signed-off-by: Kong's Team k8s bot <[email protected]> --------- Signed-off-by: Diana <[email protected]> Signed-off-by: Mattia Lavacca <[email protected]> Signed-off-by: Kong's Team k8s bot <[email protected]> Co-authored-by: Diana <[email protected]> Co-authored-by: Mattia Lavacca <[email protected]> Co-authored-by: Travis Raines <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]> Co-authored-by: Michael Heap <[email protected]> Co-authored-by: Kong's Team k8s bot <[email protected]>
Description
Revises the Events section of the KIC troubleshooting guide to provide a more detailed example and cover the new Event type to be introduced in 2.9 for Kong/kubernetes-ingress-controller#3551
Adds a note to HTTPRoute documentation indicating that we don't support port restrictions per the GWAPI spec, for Kong/kubernetes-ingress-controller#3315
Testing instructions
Awaiting Netlify.
Revised example is derived from a local runthrough of an Event search.
Checklist
main
for immediate publishing, or a release branch: e.g.release/gateway-3.2
,release/deck-1.17
)Latter bit is sort of a lie. We don't have a running release branch for KIC 2.9. This also does not add a separate 2.9 version gate in the source because the end user experience for the new 2.9 Event type is virtually identical to the 2.8 experience--the only differences are the Event reason and the situations that cause them (we don't cover the situations in depth though, and it's mostly a technical distinction--users need to fix some problem with a resource regardless of whether KIC catches the problem in translation or apply). The doc does mention this discrepancy with a note admonition.
May make sense to just leave this un-merged after review until 2.9 is out, or just go ahead and merge it (we intend to release 2.9 soon).