docs(kic): update kic 2.9 nav #5253

mlavacca · 2023-03-06T10:42:18Z

Description

nav updated for KIC 2.9 upcoming release. This update is needed to be coherent with the titles we already have for TCPRoute and UDPRoute.

Testing instructions

Netlify link:

Checklist

Review label added
PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

app/_data/docs_nav_kic_2.9.x.yml

github-actions · 2023-03-06T10:49:39Z

⚠️ Please add at least one of the following review labels to this PR:

review:copyedit: Request for writer review.
review:general: Review for general accuracy and presentation.
Does the doc work? Does it output correctly?
review:tech: Request for technical review for a docs platform change.
review:sme: Request for review from an SME (engineer, PM, etc.).

Note: Only Kong employees can add labels due to a GitHub limitation.
If you're an OSS contributor, thank you! The maintainers will label this PR for you.

github-actions · 2023-03-06T10:51:23Z

⚠️ Please add at least one of the following review labels to this PR:

review:copyedit: Request for writer review.
review:general: Review for general accuracy and presentation.
Does the doc work? Does it output correctly?
review:tech: Request for technical review for a docs platform change.
review:sme: Request for review from an SME (engineer, PM, etc.).

Note: Only Kong employees can add labels due to a GitHub limitation.
If you're an OSS contributor, thank you! The maintainers will label this PR for you.

app/_data/docs_nav_kic_2.9.x.yml

pmalek · 2023-03-06T17:03:53Z

Looks good for me (locally built, and renders fine).

That might be a stretch but what would you say about updating the list of guides on the /guides/overview/ page to reflect this change? I can already see that this list doesn't include the UDP guide so we might add this (and gRPC one obviously) while we're at it. WDYT?

mlavacca · 2023-03-06T17:24:18Z

Looks good for me (locally built, and renders fine).

That might be a stretch but what would you say about updating the list of guides on the /guides/overview/ page to reflect this change? I can already see that this list doesn't include the UDP guide so we might add this (and gRPC one obviously) while we're at it. WDYT?

Yeah, it makes sense as well. I'll update the list 👍

mlavacca · 2023-03-07T09:50:47Z

@pmalek I updated the overview section as well. PTAL

app/_src/kubernetes-ingress-controller/guides/overview.md

pmalek

🎖️

Signed-off-by: Mattia Lavacca <[email protected]>

* Add 2.9 nav file and 2.9 version to version file Signed-off-by: Diana <[email protected]> * docs: GRPCRoute guide (#5216) docs: GRPCRoute guide added Signed-off-by: Mattia Lavacca <[email protected]> * Update KIC troubleshooting for 2.9 and add GWAPI port note (#5196) * chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]> * KIC 2.9.x update deployment guides - Gateway Discovery (#5231) * feat(kic): add docs about Gateway Discovery --------- Co-authored-by: Grzegorz Burzyński <[email protected]> * chore(kic) extract common docs to includes (#5256) Co-authored-by: Michael Heap <[email protected]> * docs(kic): update kic 2.9 nav (#5253) Signed-off-by: Mattia Lavacca <[email protected]> * doc(kic): update compatibility tables for 2.9 (#5259) * kic: show Gateway Discovery guide entry for versions 2.9+ * chore(kic): fix code block languages * chore(kic): fix incorrect helm.sh link * GatewayAlpha feature-gate added to grpc guide (#5323) kic: update grpcRoute GatewayAlpha FG Signed-off-by: Mattia Lavacca <[email protected]> * Update docs for KIC 2.9.0 (#5360) Synchronize auto-generated KIC API reference Signed-off-by: Kong's Team k8s bot <[email protected]> Co-authored-by: Travis Raines <[email protected]> * chore(kic) update CRD links in nav * chore(kic) generate 2.8 KIC CRD reference (#5361) Synchronize auto-generated KIC API reference Signed-off-by: Kong's Team k8s bot <[email protected]> --------- Signed-off-by: Diana <[email protected]> Signed-off-by: Mattia Lavacca <[email protected]> Signed-off-by: Kong's Team k8s bot <[email protected]> Co-authored-by: Diana <[email protected]> Co-authored-by: Mattia Lavacca <[email protected]> Co-authored-by: Travis Raines <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]> Co-authored-by: Michael Heap <[email protected]> Co-authored-by: Kong's Team k8s bot <[email protected]>

* Add 2.9 nav file and 2.9 version to version file Signed-off-by: Diana <[email protected]> * docs: GRPCRoute guide (Kong#5216) docs: GRPCRoute guide added Signed-off-by: Mattia Lavacca <[email protected]> * Update KIC troubleshooting for 2.9 and add GWAPI port note (Kong#5196) * chore: wrap source and fix minor errors * chore: fix KIC webhook article title * doc(kic) revise event troubleshooting Update the KIC troubleshooting guide with additional information about troubleshooting using Events, including the configuration push Event type to be introduced in 2.9. Rewrite the example as a more complete guide, with example problem resources, example queries, and issue remediation. * doc(kic) add HTTPRoute port limitation warning * Apply suggestions from code review Co-authored-by: Diana <[email protected]> * Fix Vale errors Signed-off-by: Diana <[email protected]> * pr: VAW title change * pr: clarify and gate version note --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]> * KIC 2.9.x update deployment guides - Gateway Discovery (Kong#5231) * feat(kic): add docs about Gateway Discovery --------- Co-authored-by: Grzegorz Burzyński <[email protected]> * chore(kic) extract common docs to includes (Kong#5256) Co-authored-by: Michael Heap <[email protected]> * docs(kic): update kic 2.9 nav (Kong#5253) Signed-off-by: Mattia Lavacca <[email protected]> * doc(kic): update compatibility tables for 2.9 (Kong#5259) * kic: show Gateway Discovery guide entry for versions 2.9+ * chore(kic): fix code block languages * chore(kic): fix incorrect helm.sh link * GatewayAlpha feature-gate added to grpc guide (Kong#5323) kic: update grpcRoute GatewayAlpha FG Signed-off-by: Mattia Lavacca <[email protected]> * Update docs for KIC 2.9.0 (Kong#5360) Synchronize auto-generated KIC API reference Signed-off-by: Kong's Team k8s bot <[email protected]> Co-authored-by: Travis Raines <[email protected]> * chore(kic) update CRD links in nav * chore(kic) generate 2.8 KIC CRD reference (Kong#5361) Synchronize auto-generated KIC API reference Signed-off-by: Kong's Team k8s bot <[email protected]> --------- Signed-off-by: Diana <[email protected]> Signed-off-by: Mattia Lavacca <[email protected]> Signed-off-by: Kong's Team k8s bot <[email protected]> Co-authored-by: Diana <[email protected]> Co-authored-by: Mattia Lavacca <[email protected]> Co-authored-by: Travis Raines <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]> Co-authored-by: Michael Heap <[email protected]> Co-authored-by: Kong's Team k8s bot <[email protected]>

mlavacca requested a review from a team as a code owner March 6, 2023 10:42

mlavacca requested a review from a team March 6, 2023 10:42

pmalek approved these changes Mar 6, 2023

View reviewed changes

app/_data/docs_nav_kic_2.9.x.yml Outdated Show resolved Hide resolved

mlavacca added the do not merge Issues/ PRs whose changes should not be merged at this time label Mar 6, 2023

mlavacca added the review:copyedit Request for writer review. label Mar 6, 2023

cloudjumpercat reviewed Mar 6, 2023

View reviewed changes

app/_data/docs_nav_kic_2.9.x.yml Show resolved Hide resolved

pmalek force-pushed the release/kic-2.9 branch from 1f31316 to 05d933f Compare March 6, 2023 15:10

mlavacca force-pushed the mlavacca/update-docs-nav-grpc branch 3 times, most recently from f257f5c to d8d1709 Compare March 6, 2023 16:53

mlavacca requested review from cloudjumpercat and pmalek March 6, 2023 16:59

mlavacca force-pushed the mlavacca/update-docs-nav-grpc branch from d8d1709 to e8247d1 Compare March 6, 2023 18:09

pmalek reviewed Mar 7, 2023

View reviewed changes

app/_src/kubernetes-ingress-controller/guides/overview.md Outdated Show resolved Hide resolved

mlavacca force-pushed the mlavacca/update-docs-nav-grpc branch from e8247d1 to 7bd4a9b Compare March 7, 2023 10:06

mlavacca requested a review from pmalek March 7, 2023 10:08

pmalek approved these changes Mar 7, 2023

View reviewed changes

docs(kic): update kic 2.9 nav

38c9178

Signed-off-by: Mattia Lavacca <[email protected]>

mlavacca force-pushed the mlavacca/update-docs-nav-grpc branch from 6e099c3 to 38c9178 Compare March 7, 2023 10:17

mlavacca merged commit 97e813c into release/kic-2.9 Mar 7, 2023

mlavacca deleted the mlavacca/update-docs-nav-grpc branch March 7, 2023 10:18

pmalek pushed a commit that referenced this pull request Mar 7, 2023

docs(kic): update kic 2.9 nav (#5253)

05daccc

Signed-off-by: Mattia Lavacca <[email protected]>

pmalek pushed a commit that referenced this pull request Mar 8, 2023

docs(kic): update kic 2.9 nav (#5253)

338b2f1

Signed-off-by: Mattia Lavacca <[email protected]>

pmalek pushed a commit that referenced this pull request Mar 9, 2023

docs(kic): update kic 2.9 nav (#5253)

3f73f01

Signed-off-by: Mattia Lavacca <[email protected]>

pmalek pushed a commit that referenced this pull request Mar 17, 2023

docs(kic): update kic 2.9 nav (#5253)

ee500b6

Signed-off-by: Mattia Lavacca <[email protected]>

pmalek pushed a commit that referenced this pull request Mar 17, 2023

docs(kic): update kic 2.9 nav (#5253)

fc151b4

Signed-off-by: Mattia Lavacca <[email protected]>

pmalek pushed a commit that referenced this pull request Mar 17, 2023

docs(kic): update kic 2.9 nav (#5253)

2f9c547

Signed-off-by: Mattia Lavacca <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(kic): update kic 2.9 nav #5253

docs(kic): update kic 2.9 nav #5253

mlavacca commented Mar 6, 2023 •

edited

Loading

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

pmalek commented Mar 6, 2023

mlavacca commented Mar 6, 2023

mlavacca commented Mar 7, 2023

pmalek left a comment

docs(kic): update kic 2.9 nav #5253

docs(kic): update kic 2.9 nav #5253

Conversation

mlavacca commented Mar 6, 2023 • edited Loading

Description

Testing instructions

Checklist

github-actions bot commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

pmalek commented Mar 6, 2023

mlavacca commented Mar 6, 2023

mlavacca commented Mar 7, 2023

pmalek left a comment

Choose a reason for hiding this comment

mlavacca commented Mar 6, 2023 •

edited

Loading