-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parallelize the integration test suite #1669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
changed the title
Parallelize integration tests
feat: parallelize the integration test suite
Aug 5, 2021
shaneutt
added
area/ci
area/maintenance
Cleanup, refactoring, and other maintenance improvements that don't change functionality.
area/perf
Performance Related Issues
labels
Aug 5, 2021
5 tasks
shaneutt
force-pushed
the
parallelize-integration-tests
branch
2 times, most recently
from
August 5, 2021 20:45
c1aabb8
to
092241d
Compare
created by the test.Main unless they need another ctx for their specific use case.
Previously test cases had a tendency to create their own namespaces, manage them and clean them up themselves, e.t.c. Using recent functionality from KTF, this patch converts all test cases to use an inherent generated namespace which will be created uniquely for them on each test run.
shaneutt
force-pushed
the
parallelize-integration-tests
branch
from
August 5, 2021 21:27
092241d
to
7c6e0b7
Compare
Codecov Report
@@ Coverage Diff @@
## next #1669 +/- ##
===========================================
- Coverage 62.36% 46.17% -16.19%
===========================================
Files 81 70 -11
Lines 7272 6837 -435
===========================================
- Hits 4535 3157 -1378
- Misses 2403 3307 +904
- Partials 334 373 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rainest
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
area/maintenance
Cleanup, refactoring, and other maintenance improvements that don't change functionality.
area/perf
Performance Related Issues
ci/license/unchanged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes several changes to our integration test suite:
default
is no longer supported)test/performance
as these tests are costly and noisy, and now with parallelization of tests some of their value has been replacedWhich issue this PR fixes
Resolves #1592
Notes
I ran
./hack/e2e/run-tests.sh
locally to verify these changes in our release testing, and it's working properly on GKE.