Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject unsupported resources when expression router enabled and attach translationError events #4000

Closed
2 of 3 tasks
randmonkey opened this issue May 15, 2023 · 0 comments · Fixed by #4022
Closed
2 of 3 tasks
Assignees
Labels
area/feature New feature or request
Milestone

Comments

@randmonkey
Copy link
Contributor

randmonkey commented May 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Because Kong does not support stream proxies when expression router enabled, we could not support the following kubernetes resources when ExpressionRoutes enabled:
TCPIngress, UDPIngress, TCPRoute, UDPRoute, TLSRoute
Also, we intentionally dropped support of the following resources:
kantive.Ingress, networking.k8s.io/v1beta1.Ingress,extensions/v1beta1.Ingress.
To prevent them from generating traditional routes that will pollute the whole kong configuration, we need to disable their translation and attach a TranslationError event to them.

Proposed Solution

  • Attach TranslationError event to the unsupported objects in parser if ExpressionRoutes is enabled

Additional information

No response

Acceptance Criteria

  • The unsupported resources does not get translated to kong configurations when ExpressionRoutes enabled.
  • TransalationError type events are attached to unsupported resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
1 participant