Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attach translation failure events to unsupported objects when ExpressionRoutes enabled #4022

Merged
merged 3 commits into from
May 18, 2023

Conversation

randmonkey
Copy link
Contributor

What this PR does / why we need it:

When expression router is enabled, we disable translation of the following unsupported objects:

  • knative.Ingress
  • TCPIngress
  • UDPIngress
  • TCPRoute
  • UDPRoute
  • TLSRoute

And generate a translation failure event to each of the objects.
Also, this PR adds an integration test to verify it.

Which issue this PR fixes:

fixes #4000
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner May 17, 2023 10:17
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: -0.1 ⚠️

Comparison is base (ed7c864) 59.6% compared to head (daf081c) 59.6%.

❗ Current head daf081c differs from pull request most recent head 631a525. Consider uploading reports for the commit 631a525 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4022     +/-   ##
=======================================
- Coverage   59.6%   59.6%   -0.1%     
=======================================
  Files        149     149             
  Lines      16406   16434     +28     
=======================================
+ Hits        9792    9807     +15     
- Misses      5979    5995     +16     
+ Partials     635     632      -3     
Impacted Files Coverage Δ
internal/dataplane/parser/parser.go 75.5% <100.0%> (+0.4%) ⬆️
internal/dataplane/parser/translate_knative.go 88.6% <100.0%> (+0.2%) ⬆️
internal/dataplane/parser/translate_kong_l4.go 55.4% <100.0%> (+3.0%) ⬆️
internal/dataplane/parser/translate_tcproute.go 17.2% <100.0%> (+6.3%) ⬆️
internal/dataplane/parser/translate_tlsroute.go 10.7% <100.0%> (+4.0%) ⬆️
internal/dataplane/parser/translate_udproute.go 17.2% <100.0%> (+6.3%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randmonkey randmonkey force-pushed the feat/disable_translation_nonsupported_resources branch from c75b659 to e112d49 Compare May 17, 2023 10:30
@randmonkey randmonkey force-pushed the feat/disable_translation_nonsupported_resources branch from e112d49 to daf081c Compare May 18, 2023 03:54
@randmonkey randmonkey added this to the KIC v2.10.0 milestone May 18, 2023
@randmonkey randmonkey force-pushed the feat/disable_translation_nonsupported_resources branch from daf081c to 631a525 Compare May 18, 2023 09:15
@randmonkey randmonkey enabled auto-merge (squash) May 18, 2023 09:19
@randmonkey randmonkey merged commit 6ce0245 into main May 18, 2023
@randmonkey randmonkey deleted the feat/disable_translation_nonsupported_resources branch May 18, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reject unsupported resources when expression router enabled and attach translationError events
3 participants