Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow ExpressionRoutes feature gate when CombinedRoutes not enabled #4043

Closed
1 of 2 tasks
randmonkey opened this issue May 19, 2023 · 0 comments · Fixed by #4057
Closed
1 of 2 tasks

Disallow ExpressionRoutes feature gate when CombinedRoutes not enabled #4043

randmonkey opened this issue May 19, 2023 · 0 comments · Fixed by #4057
Assignees
@randmonkey
Labels
area/feature New feature or request
Milestone
KIC v2.10.0

Comments

@randmonkey
Copy link
Contributor

randmonkey commented May 19, 2023 •
edited by mflendrich
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

We decided not to support translating to expression based routes if CombinedRoutes is not enabled. So we need to disable KIC parser to translate to expression based routes, if ExpressionRoutes is enabled, but CombinedRoutes is not.

Proposed Solution

  • disable ExpressionRoutes feature in parser if ExpressionRoutes is enabled but CombinedRoutes not enabled.

Additional information

No response

Acceptance Criteria

  • KIC refuses to start up when feature gate ExpressionRoutes enabled but CombinedRoutes is not enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randmonkey randmonkey

Labels
area/feature New feature or request
Projects
None yet
Milestone
KIC v2.10.0
1 participant
@randmonkey