Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable expression routes mode when ExpressionRoutes is on but CombinedRoutes is off #4057

Merged

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented May 23, 2023

What this PR does / why we need it:

Since we did not implement the translator for ingresses and httproutes to expression based routes, we disable expression routes mode of parser when ExpressionRoutes is enabled but CombinedRoutes is disabled.

Which issue this PR fixes:

fixes #4043

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner May 23, 2023 06:51
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: +0.1 🎉

Comparison is base (5d29975) 59.8% compared to head (4b0aa51) 59.9%.

❗ Current head 4b0aa51 differs from pull request most recent head c9af630. Consider uploading reports for the commit c9af630 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4057     +/-   ##
=======================================
+ Coverage   59.8%   59.9%   +0.1%     
=======================================
  Files        149     149             
  Lines      16482   16491      +9     
=======================================
+ Hits        9862    9892     +30     
+ Misses      5988    5971     -17     
+ Partials     632     628      -4     
Impacted Files Coverage Δ
internal/dataplane/parser/parser.go 75.9% <100.0%> (+1.1%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

internal/dataplane/parser/parser.go Outdated Show resolved Hide resolved
internal/dataplane/parser/parser.go Outdated Show resolved Hide resolved
@randmonkey randmonkey requested a review from pmalek May 23, 2023 09:21
@randmonkey randmonkey enabled auto-merge (squash) May 23, 2023 09:22
@randmonkey randmonkey merged commit 1db7c5b into main May 23, 2023
@randmonkey randmonkey deleted the disable_expression_routes_when_combined_routes_disabled branch May 23, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow ExpressionRoutes feature gate when CombinedRoutes not enabled
2 participants