Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a flag --process-classless-ingress-v1beta1 #732

Closed
hbagdi opened this issue Jun 15, 2020 · 2 comments
Closed

implement a flag --process-classless-ingress-v1beta1 #732

hbagdi opened this issue Jun 15, 2020 · 2 comments
Labels
area/feature New feature or request
Milestone

Comments

@hbagdi
Copy link
Member

hbagdi commented Jun 15, 2020

Once #731 is implemented, a user should be able to change the behavior of the controller to be same as that in 0.9.0, which is, it will satisfy ingress resources which do not contain a kubernetes.io/ingress.class annotation.

The scope here:

  • come up with a better name for the flag, if you can't, use the one in the issue title
  • implement the flag (and corresponding behavior in the controller)
  • the default value for the flag should be false

For background, please see the doc in #690.

@hbagdi hbagdi added the area/feature New feature or request label Jun 15, 2020
@hbagdi hbagdi added this to the 0.10.0 milestone Jun 15, 2020
@hbagdi hbagdi added the trello label Jun 15, 2020
@rainest
Copy link
Contributor

rainest commented Aug 19, 2020

Modified community flag toggling the old behavior off to default to this in fb3ab86. The renamed flags flips the default behavior to not ingest classless ingresses, i.e. false.

@rainest
Copy link
Contributor

rainest commented Aug 26, 2020

Handled in #767.

@rainest rainest closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants