Update remaining resource ingress.class behaviors #815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
"kong"
string in tests.Which issue this PR fixes
fixes #739
fixes #731
Special notes for your reviewer:
Changes for #731 are a composite of this and the implementation for #732, which was merged in #767. See comments in #731 for additional details.
We had originally discussed also rolling removal of the
ListGlobalKongPlugins()
store function into this, but on further review, we should leave that in. We list them only to report that they're there and instruct users to convert them to KongClusterPlugins:kubernetes-ingress-controller/internal/ingress/controller/parser/parser.go
Lines 1593 to 1601 in de29e98
ListGlobalKongPlugins()
is still a bit odd as it sorta still used the legacy matching behavior: it tracked the Ingress matching behavior, but that has since changed. Tracking it now would omit warnings for global KongPlugins with no class annotation (which were previously processed if you used the default "kong" class). As such, this PR preserves the function, but always uses ExactOrEmptyMatching to try and match the old behavior as best possible.