Support custom entities in Railgun #1339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add the kong-custom-entities-secret flag to Railgun, load the specified Secret, and pass it to sendconfig.PerformUpdate().
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #1306Special notes for your reviewer:
Testing: good question! For https://docs.konghq.com/kubernetes-ingress-controller/1.2.x/guides/configuring-custom-entities/ you need a plugin that actually defines custom entities. The core plugin suite doesn't really have any of these--oauth2 does but it's not available in DB-less mode. We're kinda stuck for custom entity integration tests unless we want to build a custom Kong image that includes such a plugin.