Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It seems that custom entities where never used (at least in a handful of recent versions).
The notion of them was "somehow" introduced in #1339 and #2296 made
sendconfig.PerformUpdate()
always passnil
in place for "custom entities".Since it's always
nil
we may as well just delete it altogether.Special notes for your reviewer:
There is still the CLI flag
I'd argue that we can add a deprecation notice and state that it doesn't do anything now and that it will be removed in next major release. WDYT?This PR marked the flag as deprecated with
flagSet.MarkDeprecated
.