-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kustomizations and tooling to create 2.x manifests #1563
Conversation
Add Kustomize manifests for 2.x. Many of these are links to existing 1.x manifests that require no changes for 2.x. Uses a new location so that the original unchanged 1.x manifests can live alongside new 2.x-only content.
Add a script to compose 2.x base manifests into single/all-in-one manifests.
Codecov Report
@@ Coverage Diff @@
## next #1563 +/- ##
==========================================
+ Coverage 51.32% 51.51% +0.19%
==========================================
Files 93 93
Lines 8737 8737
==========================================
+ Hits 4484 4501 +17
+ Misses 3939 3926 -13
+ Partials 314 310 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Draft version of this attempts to more or less mimic the 1.x hack script, using the existing 1.x kustomize bases with some additional patches for 2.x. 2.x bases symlink to the 1.x bases when they don't need changes. Open questions to refine the draft into a ready PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly help to remove duplicates
- Move deploy/single to deploy/single-v1 - Move railgun/config/single to deploy/single-v2 - Update manifest generator scripts with new locations - Add v2 manifests to manifest verifier - Link deploy/single to deploy/single-v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments
Kindly split the files and remove duplicates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented.
Use the default ServiceAccount in 2.x role bindings. Remove the patch that previously overwrote the ServiceAccount for the 2.x all-in-one manifests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have no hard blocks 👍
I do however have a few comments about follow ups for some of these hardcoded versions, and to make sure we're following up on the TODO item from the script, once those are complete and other people's comments are complete ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after removing the tmp-binding.yaml. Thanks for working hard removing duplicates, I know it is challenge, but we'll get there.
What this PR does / why we need it:
deploy/single-v2
deploy/single-v1
and linkdeploy/single
todeploy/single-v1
. We should flip this to v2 once v2 is GA.Which issue this PR fixes: Fixes #1256
Special notes for your reviewer:
kubectl apply -f deploy/single-v2/all-in-one-dbless.yaml
and so on in a test cluster is a more effective review strategy.tmp-bindings.yaml
. If it was generated, however, I need to fix the source, and I don't know what that is.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR