Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] enable all v1 crds for kustomize #1577

Closed
wants to merge 1 commit into from
Closed

Conversation

shaneutt
Copy link
Contributor

What this PR does / why we need it:

The Kustomize configuration for CRDs was missing configuration for all our CRDs, this fixes that.

Which issue this PR fixes

Doesn't complete, but is in support of Kong/charts#391

@shaneutt shaneutt added bug Something isn't working priority/medium labels Jul 22, 2021
@shaneutt shaneutt self-assigned this Jul 22, 2021
@shaneutt shaneutt requested a review from a team as a code owner July 22, 2021 16:24
@shaneutt shaneutt temporarily deployed to Configure ci July 22, 2021 16:24 Inactive
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #1577 (c529d96) into next (f76b19b) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1577      +/-   ##
==========================================
+ Coverage   51.32%   51.35%   +0.03%     
==========================================
  Files          93       93              
  Lines        8737     8737              
==========================================
+ Hits         4484     4487       +3     
+ Misses       3939     3936       -3     
  Partials      314      314              
Flag Coverage Δ
integration-test 46.99% <ø> (+0.10%) ⬆️
unit-test 39.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
railgun/internal/ctrlutils/ingress-status.go 64.64% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76b19b...c529d96. Read the comment docs.

@shaneutt
Copy link
Contributor Author

#1563 will solve this anyhow, so we don't need this duplicate.

@shaneutt shaneutt closed this Jul 22, 2021
@shaneutt shaneutt deleted the kustomize-all-crds branch July 22, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant