Segment/clip not showing whole last note in Song Editor

[Sti2nd]

I think it is because of the "outline"/borderline which is really an inline leaves less space for viewing the notes.

vs. how LMMS 0.4.15 shows it

0.4.15 is a little bit better. From the last segment it seems like the note is actually drawn on top of the black outline? Is the first note not drawn from the first pixel? You still have the problem of cutting of the last note (visually) in 0.4.15 when a new segment follows immediately after.

I guess the code is still the same, thus with less space for the actual note view because of the outline. The fact that the last note was already cut off in 0.4.15, makes the last note look like a tiny pixel from version 1.0.0. So I guess the box the notes is allowed to draw in should be reduced with one pixel in all directions? This would still cut off the last note as in 0.4.15, though.

[tresf]

You have two issues:

1. Poor contrast between piano roll preview notes and preview border color.
2. Last note is cropped in piano roll preview.

Both valid, but completely separate issues.

Thanks for screenshots. From your example it seems # 2 has been around for a while.

I recommend filing two bug reports as these two issues are not related.

[Sti2nd]

1. Hmm, my eyes can't see that the borderline goes behind the note, but I might not be able to see it because of contrast, indeed.

I would say I have three issues for the graphical to be improved.
3. The borders have made the draw area for a pattern/segment smaller.
So that should have been updated with the implementation of the borders, although I don't know how an even smaller area would be 💭

[badosu]

@tresf Can we close this one? #1506 was merged.

[tresf]

👍