Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for 1255 Segment/clip not showing whole last note in Song E... #1506

Merged
merged 2 commits into from
Jan 4, 2015
Merged

Proposed fix for 1255 Segment/clip not showing whole last note in Song E... #1506

merged 2 commits into from
Jan 4, 2015

Conversation

curlymorphic
Copy link
Contributor

Proposed fix for #1255 Segment/clip not showing whole last note in Song Editor

image

@Sti2nd
Copy link
Contributor

Sti2nd commented Dec 26, 2014

Oh HELL YEAH. Thank U

@badosu
Copy link
Contributor

badosu commented Dec 26, 2014

The highest pitch note looks snapped to the top, is this an easy fix to push here too?

@tresf
Copy link
Member

tresf commented Dec 26, 2014

The highest pitch note looks snapped to the top, is this an easy fix to push here too?

IIRC, that was intentional. I'll leave that answer up to Vesa and Dave.

@curlymorphic
Copy link
Contributor Author

The highest pitch note looks snapped to the top, is this an easy fix to push here too?

I think that is meant to be like that. To me this is an issue with the notes and the border being the same color making the top note hard to see. Guess we had better ask @diizy for advise

@badosu
Copy link
Contributor

badosu commented Dec 26, 2014

@curlymorphic @tresf It's cool, this is not even related to the original issue. 👍

@diizy
Copy link
Contributor

diizy commented Dec 26, 2014

On 12/26/2014 06:51 PM, Dave wrote:

The highest pitch note looks snapped to the top, is this an easy
fix to push here too?

I think that is meant to be like that. To me this is an issue with the
notes and the border being the same color making the top note hard to
see. Guess we had better ask @diizy https:/diizy for advise

You could add a 1 px offset to the top edge if you want.

@curlymorphic
Copy link
Contributor Author

You could add a 1 px offset to the top edge if you want.

Sure will do

@badosu
Copy link
Contributor

badosu commented Dec 26, 2014

Just checked, looking pretty good!

diizy added a commit that referenced this pull request Jan 4, 2015
Proposed fix for 1255 Segment/clip not showing whole last note in Song E...
@diizy diizy merged commit 469cb98 into LMMS:master Jan 4, 2015
@curlymorphic curlymorphic deleted the i1255 branch July 5, 2015 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants