-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top bar master level meter proposal #4
Comments
Hmm. Isn't it a bit redundant, when there's already a master peak meter in the fx mixer? I think maybe a more flexible solution would be being able to switch the master scope between different views, like waveform scope, spectrum analyzer, master levels, flying toasters... |
I think this has a lot of overlap with the reuse of real-estate which is already on our futuremap. Furthermore, it is an enhancement that has no driving force behind it and is already covered by an existing feature. Marking as |
You should check if diizy's suggestion is on the roadmap, or should I make a new enhancement?
I wouldn't say this enhancement is already covered in the software, having a big window like the FX mixer open just to watch the master clipping is annoying, that is one reason I don't understand why @diizy absolutely wanted to have at least the width of six channels. With a mizer width of just one, or just the master channel, this enhancement would indeed be covered. |
Off topic.
The main window has many items that are or will be under redesign. This specific bar is a bit too... well... specific to keep open for a layout that plans to undergo major changes anyway. For now, you can make mixer window always on top and drag it to the right so it's mostly off of the screen. If you want to reopen this, we can, but we have too many stale bug reports that won't ever get worked on without some research and effort behind them, so I invite the person that wants this feature to start researching and making mockups to warrant it's resurrection prior to any major overhauls that may come... In the mean time, how about we wait for some better toolbars and what they offer. This feature will make its way into some UI redesigns in one way or another. |
P.S. We should probably re-use the main volume slider as a level meter/peak indicator anyway, don't you think? :) |
Could be smart, though I only want to see the clipping so a light with the colors green, yellow and red would work too. |
* Changes mousePressEvent variables to camelCase Changes variable names from PianoRoll::mousePressEvent to camelCase and changes 2 comments. * Style fixes on mouseDoubleClickEvent * Removes magic number and costy loop Removes a loop that removed every note except one and replaced it with a clear() call plus appending the note. Removes a magic number used for finding the closest note. * Small fixes + Code style Fixes small bug with the vertical selection mode scrolling. Improves logic on the cursor selection of ActionNone. Adds update() + return statements for the actions that didn't have them, and removed the update() from outside the switch. Fixes the code style. * Adds Remove Note action Adds a action to remove notes on the PianoRoll, and remove an unnecessary member variable that was only being used to handle that action (m_mouseDownRight). Also removes unnecessary handling of the play key action on the ActionNone case switch from the mouseMoveEvent. Adds a update() call on the ActionPlayKeys (so it updates the cursor) and a break; statement for consistency. Also fixes the calculation of the velocity.
* etc)컴파일 에러 수정 형변환으로 인한 컴파일 에러 수정 (형변환이 엄격한 컴파일러에서 에러가 발생) * fea)midi 파일을 불러올때 미디파일 데이터 갱신하도록 수정 미디 파일 정보를 읽은 후 모든 Model 정보의 signal 함수(dataChanged)을 호출 하도록 수정 * sty)signal 함수(dataInit) 추가 같은 코드에 signal함수를 추가하여 동작하도록 코드 설계 스타일 수정함
Hi as most daws have the feature of a level meter to show the master volume of the mixer in the top bar, i believe LMMS would also benefit from having this feature. i have added a mockup of how this would look in LMMS and the 2 required files i.e the background and foreground images.
thanks Mikobuntu :)
The text was updated successfully, but these errors were encountered: