Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3674: Pattern names difficult to read #3691

Conversation

michaelgregorius
Copy link
Contributor

Make the pattern names better readable by rendering them on top of a semitransparent black rectangle. Elide the text and make it render a bit more to the right.

Use the font properties that are defined in the CSS to draw the pattern labels. This provides flexibility with regards to the font properties that are used (size, font family, etc.).

Adjust the CSS for the default theme and the classic theme.

Make the pattern names better readable by rendering them on top of a
semitransparent black rectangle. Elide the text and make it render a bit
more to the right.
Use the font properties that are defined in the CSS to draw the pattern
labels. This provides flexibility with regards to the font properties
that are used (size, font family, etc.).

Adjust the CSS for the default theme and the classic theme.
@michaelgregorius michaelgregorius merged commit a70d255 into LMMS:master Jul 11, 2017
@michaelgregorius michaelgregorius deleted the 3674-Pattern-names-difficult-to-read branch July 11, 2017 19:24
@Umcaruje
Copy link
Member

This change has brought an UI inconsistency with the other patterns:
screenshot from 2017-07-15 23 23 19

I vote the same rectangle background gets implemented in other TCO's. Also for theming purposes, the rectangle color should be available through CSS, so the opacity can be freely changed.

Sorry for reviewing the PR this late, I never got around to it.

@michaelgregorius
Copy link
Contributor Author

@Umcaruje Solved with #3704. For now I have only added the method TrackContentObjectView::paintTextLabel which is then called in the paint code of all inheriting classes. However, in the long run it might make sense to move the painting code that's shared by all pattern types to TrackContentObjectView and to only keep the specialized logic in the inherited pattern views.

@Umcaruje
Copy link
Member

However, in the long run it might make sense to move the painting code that's shared by all pattern types to TrackContentObjectView and to only keep the specialized logic in the inherited pattern views

Agree on that 100%, checking out the PR now.

@michaelgregorius
Copy link
Contributor Author

Inconsistencies have been fixed with the merge of #3704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants