Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to JOSS manuscript #18

Closed
hiendn opened this issue Sep 20, 2018 · 2 comments
Closed

Corrections to JOSS manuscript #18

hiendn opened this issue Sep 20, 2018 · 2 comments

Comments

@hiendn
Copy link

hiendn commented Sep 20, 2018

Please make the corrections from the marked up file that has been attached. Please also conduct a thorough proof reading once you have made the corrections, since I may have missed some things.

10.21105.joss.00961.pdf

@dirmeier
Copy link

dirmeier commented Sep 23, 2018

In addition to the corrections mentioned by @hiendn, please find a list of minor revisions and comments below:

  • There are many typos and grammatical errors. Please make sure to remove them.
  • Even though I understand your point, from the intro it does not get clear to someone not working in the field how survival analysis models and your tool are related to NNs or RFs, or rather it does not get enough emphasis. You motivate your problem with the interpretability of models that are "complex in structure", yet only show local method plots for a simple Cox proportional hazard model where intepretation of the coefficients is relatively simple, right? I understand that this is only a simple use case that could be generalized to more complex problems, but I believe you could maybe better motivate this, e.g. by showing a more elaborate use case, for instance when the Cox model is parametrized by an NN. This is however only a comment and I might be wrong.
  • Figure 1: why do you only describe the middle panel and not the others? E.g. what are the colors for bili?
  • Hyperlink of Eleuteri paper does not work. Also check other hyperlinks please.

@agosiewska
Copy link
Contributor

Thank you for your comments.
We've made the corrections and @AleksandraDabrowska rebuilded the pdf.
openjournals/joss-reviews#961

@hiendn hiendn closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants