-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: survxai: an R package for model agnostic explanations of survival models #961
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @hiendn, it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https:/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
Hi @AleksandraDabrowska, I am one of your reviewers! My comments and suggestions will be posted on the issues page of your repository. |
Yeah, exactly. From my side these two and 20. All of them are minor changes. |
@yochannah that's correct, resolving 22 would be good as well, if possible. |
👋 @AleksandraDabrowska - any progress or ETA for the ticket revisions? |
Hey @AleksandraDabrowska - could you rebuild the pdf once you are finished with the reviews? Then I can close the respective issues in your repository. |
@whedon generate pdf |
|
@whedon generate pdf |
|
I am now entirely happy with the with article. |
Likewise. A very nice package, too! :) |
@hiendn @dirmeier Thank you very much for reviewing and for your kind words! :) |
@AleksandraDabrowska Looking good! Before generating the archive, though, there is one issue with the manuscript I'd like to fix. Figures 3 and 4 are interspersed with the references in the most recent proof, but I'm reasonably sure they should be up in the main paper text. Can you fix this? Once this is fixed, please do generate an archive and share the URL in this thread!! 🎉 |
@whedon generate pdf |
|
@yochannah here is archive https://zenodo.org/record/1477857#.W-AtQiDdg2w |
The figures look better! Thanks @AleksandraDabrowska |
@whedon set http://doi.org/10.5281/zenodo.1477857 as archive |
OK. 10.5281/zenodo.1477857 is the archive. |
@arfon I think we're ready to accept this one! |
@whedon accept |
|
Check final proof 👉 openjournals/joss-papers#48 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#48, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
@hiendn, @dirmeier - many thanks for your reviews here, and to @yochannah for editing this submission ✨ @AleksandraDabrowska - your paper is now accepted into JOSS ⚡ 🚀 💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @AleksandraDabrowska (Aleksandra Grudziąż)
Repository: https:/MI2DataLab/survxai
Version: 0.2.0
Editor: @yochannah
Reviewer: @hiendn, @dirmeier
Archive: 10.5281/zenodo.1477857
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@hiendn & @dirmeier, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @yochannah know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @hiendn
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @dirmeier
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: