Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both "Bool" and "Tuple{Bool, Bool}" for "xtrimspine" and "ytrimspine" #2169

Closed
marcpabst opened this issue Jul 22, 2022 · 2 comments
Closed

Support both "Bool" and "Tuple{Bool, Bool}" for "xtrimspine" and "ytrimspine" #2169

marcpabst opened this issue Jul 22, 2022 · 2 comments

Comments

@marcpabst
Copy link

I think the meaning would be self-explanatory. Sometimes you want to trim only one end of the spine and currently that's not possible.

I would be happy to implement this if this is okay with the maintainers.
@jkrumbiegel
Copy link
Member

Sounds good!

@marcpabst marcpabst changed the title Support both "Bool" and "Tuple{Bool, Bool}" for "xtrimspine" and "xtrimspie" Support both "Bool" and "Tuple{Bool, Bool}" for "xtrimspine" and "ytrimspine" Jul 22, 2022
@marcpabst marcpabst mentioned this issue Jul 22, 2022
Closed
5 tasks
@SimonDanisch
Copy link
Member

Merged in #2279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Up for grabs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Tuple{Bool, Bool} for xtrimspine and ytrimspine. marcpabst/Makie.jl
3 participants
@SimonDanisch @marcpabst @jkrumbiegel