Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation of #2171 trimspines #2279

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Continuation of #2171 trimspines #2279

merged 6 commits into from
Sep 16, 2022

Conversation

jkrumbiegel
Copy link
Member

@jkrumbiegel jkrumbiegel commented Sep 16, 2022

Continuation of #2171

  • Allow Tuple{Bool, Bool} for xtrimspine and ytrimspine.
  • add entry to NEWS.md
  • Update NEWS.md
  • add test and fix reversed axis case

Description

Fixes # (issue)

Add a description of your PR here.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@github-actions
Copy link
Contributor

Missing reference images

Found 1 new images without existing references.
Upload new reference images before merging this PR.

@MakieBot
Copy link
Collaborator

MakieBot commented Sep 16, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 18.95s (18.69, 19.26) 0.22+- 22.32s (22.04, 22.67) 0.25+- 20.57s (20.24, 21.17) 0.29+- 21.19ms (20.85, 21.47) 0.23+- 95.70ms (94.50, 96.96) 0.90+-
master 19.02s (18.71, 19.41) 0.22+- 22.31s (21.96, 22.83) 0.33+- 20.49s (20.17, 21.24) 0.36+- 21.36ms (20.96, 21.68) 0.27+- 95.40ms (93.88, 96.65) 1.08+-
evaluation -0.38%, -0.07s invariant (-0.33d, 0.55p, 0.22std) +0.02%, 0.01s invariant (0.02d, 0.97p, 0.29std) +0.38%, 0.08s invariant (0.24d, 0.66p, 0.33std) -0.79%, -0.17ms invariant (-0.66d, 0.24p, 0.25std) +0.32%, 0.31ms invariant (0.31d, 0.57p, 0.99std)
CairoMakie 12.96s (12.85, 13.06) 0.08+- 18.58s (18.44, 18.81) 0.16+- 3.01s (2.98, 3.03) 0.02+- 16.57ms (16.49, 16.69) 0.08+- 24.62ms (24.42, 24.77) 0.11+-
master 12.96s (12.76, 13.13) 0.15+- 18.51s (18.26, 18.68) 0.18+- 2.99s (2.92, 3.05) 0.04+- 16.44ms (16.09, 16.92) 0.30+- 24.62ms (24.39, 24.75) 0.12+-
evaluation -0.03%, -0.0s invariant (-0.04d, 0.95p, 0.11std) +0.39%, 0.07s invariant (0.43d, 0.44p, 0.17std) +0.51%, 0.02s invariant (0.47d, 0.40p, 0.03std) +0.77%, 0.13ms invariant (0.58d, 0.31p, 0.19std) -0.01%, -0.0ms invariant (-0.03d, 0.96p, 0.11std)
WGLMakie 19.47s (19.14, 19.65) 0.20+- 27.41s (27.12, 27.78) 0.23+- 43.90s (43.31, 44.58) 0.42+- 23.07ms (22.60, 24.23) 0.57+- 1.74s (1.70, 1.79) 0.03+-
master 19.60s (19.31, 19.79) 0.17+- 27.29s (27.17, 27.67) 0.18+- 43.54s (43.27, 43.79) 0.19+- 22.76ms (22.29, 23.54) 0.55+- 1.73s (1.71, 1.76) 0.02+-
evaluation -0.67%, -0.13s invariant (-0.70d, 0.21p, 0.19std) +0.44%, 0.12s invariant (0.59d, 0.29p, 0.20std) +0.82%, 0.36s invariant (1.10d, 0.07p, 0.31std) +1.34%, 0.31ms invariant (0.56d, 0.32p, 0.56std) +0.89%, 0.02s invariant (0.64d, 0.26p, 0.02std)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants