fix RectangleZoom selection vertices #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
reviewed
Feb 13, 2023
There was a problem hiding this comment.
Thanks for the PR! One thing - no need to pass the axis to the _selection_vertices function, since you can get the transform function from the Scene.
julia> Makie.current_axis() |> Makie.transform_func
(identity, identity)
julia> Makie.current_axis().scene |> Makie.transform_func
(identity, identity)
|
Thanks for the suggestion, I updated the PR. |
asinghvi17
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2673
Type of change
Delete options that do not apply:
Checklist