Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RectangleZoom selection vertices #2674

Merged
merged 3 commits into from
Feb 13, 2023
Merged

fix RectangleZoom selection vertices #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12edbd1
fix RectangleZoom selection vertices
EdsterG Feb 13, 2023
19b0853
address PR comments
EdsterG Feb 13, 2023
01fbcdc
Update NEWS.md
ffreyer Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# News

## master
- Added the `stephist` plotting function [#2408](https:/JuliaPlots/Makie.jl/pull/2408).

- Added the `stephist` plotting function [#2408](https:/JuliaPlots/Makie.jl/pull/2408).
- Fixed an issue where `poly` plots with `Vector{<: MultiPolygon}` inputs with per-polygon color were mistakenly rendered as meshes using CairoMakie. [#2590](https:/MakieOrg/Makie.jl/pulls/2478)
- Fixed a small typo which caused an error in the `Stepper` constructor. [#2600](https:/MakieOrg/Makie.jl/pulls/2478)
- Fixed rectangle zoom for nonlinear axes [#2674](https:/MakieOrg/Makie.jl/pull/2674)

## v0.19.1

Expand Down
5 changes: 3 additions & 2 deletions src/makielayout/interactions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,9 @@ end
function _selection_vertices(ax_scene, outer, inner)
_clamp(p, plow, phigh) = Point2f(clamp(p[1], plow[1], phigh[1]), clamp(p[2], plow[2], phigh[2]))
proj(point) = project(ax_scene, point) .+ minimum(ax_scene.px_area[])
outer = positivize(outer)
inner = positivize(inner)
transf = Makie.transform_func(ax_scene)
outer = positivize(Makie.apply_transform(transf, outer))
inner = positivize(Makie.apply_transform(transf, inner))

obl = bottomleft(outer)
obr = bottomright(outer)
Expand Down