File extension rename confirmation #7024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8637630016Details
💛 - Coveralls |
david-yz-liu
reviewed
Apr 2, 2024
There was a problem hiding this comment.
@AinaMerch good work! I left a few inline comments, and also make sure to update the changelog with an entry to reflect this change.
| @@ -17,6 +17,21 @@ class SubmissionFileUploadModal extends React.Component { | |||
|
|
|||
| onSubmit = event => { | |||
| event.preventDefault(); | |||
| const newFilename = this.state.renameTo; | |||
| const originalFilename = this.state.newFiles[0].name; // Assuming only one file is uploaded | |||
There was a problem hiding this comment.
This is a good thing to observe; you should skip this check entirely if there is more than one file being submitted. Note that in this case the "Renaming" functionality is also disabled.
|
|
||
| if (originalExtension !== newExtension) { | ||
| const confirmChange = window.confirm( | ||
| "Changing the file extension may render the file unusable. Are you sure you want to proceed?" |
There was a problem hiding this comment.
This string should be internationalized
david-yz-liu
approved these changes
Apr 10, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a student uploads a file, they can choose to rename the file. However, this also allows them to change the extension of the file, which is often not really a valid operation (e.g., changing a .docx file into a .pdf). This is a front-end change to warn students who are selecting to rename a file but change the file extension, similar to the kind of confirmation dialog you would get in Windows if you try to do this. This still allows the student to actually do it (and there are some valid use cases, e.g. renaming a .txt into a .csv), but hopefully will warn students against doing so carelessly.
Motivation and Context
Your Changes
Checks for matching extensions when one tries to submit
Description:
Type of change (select all that apply):
Testing
Manually tested
Wrote front-end tests
Questions and Comments (if applicable)
Checklist
Pull request to make documentation changes (if applicable)