File extension rename confirmation

Changelog.md

@@ -10,6 +10,7 @@
 - Gave TAs read-only access to starter file information under assignment settings (#6996)
 - Allow inactive groups in the submissions table to be toggled for display (#7000)
 - Display error message for student-run tests when no test groups are runnable (#7003)
+- Added a confirmation check while renaming a file with a different extension (#7024)
 
 ## [v2.4.8]
 - Validate user-provided paths (#7025)

app/assets/javascripts/Components/Modals/submission_file_upload_modal.jsx

@@ -17,6 +17,20 @@ class SubmissionFileUploadModal extends React.Component {
 
  onSubmit = event => {
  event.preventDefault();
+ if (this.state.newFiles.length === 1) {
+ const newFilename = this.state.renameTo;
+ const originalFilename = this.state.newFiles[0].name; // Assuming only one file is uploaded
+ const originalExtension = originalFilename.split(".").pop();
+ const newExtension = newFilename.split(".").pop();
+
+ if (originalExtension !== newExtension) {
+ const confirmChange = window.confirm(I18n.t("modals.file_upload.rename_warning"));
+ if (!confirmChange) {
+ // Prevent form submission if the user cancels the operation
+ return;
+ }
+ }
+ }
  this.props.onSubmit(this.state.newFiles, undefined, this.state.unzip, this.state.renameTo);
  };
 

app/assets/javascripts/Components/__tests__/submission_file_upload_modal.test.jsx

@@ -129,4 +129,72 @@ describe("For the SubmissionFileUploadModal", () => {
  expect(wrapper.find(".file-rename-textbox").props().disabled).toBeFalsy();
  });
  });
+ describe("The onSubmit method", () => {
+ // Mock onSubmit function
+ const mockOnSubmit = jest.fn();
+
+ beforeEach(() => {
+ wrapper = shallow(
+ <SubmissionFileUploadModal
+ onlyRequiredFiles={true}
+ requiredFiles={["q1.py", "q2.py", "q3.py", "part1/p1.py"]}
+ uploadTarget={null}
+ onSubmit={mockOnSubmit} // Pass the mocked onSubmit function
+ />
+ );
+ });
+
+ it("should call onSubmit prop with correct arguments when extensions match", () => {
+ // Mock setState method
+ wrapper.setState({
+ newFiles: [{name: "file.py"}],
+ renameTo: "file.py",
+ });
+
+ // Simulate form submission
+ wrapper.instance().onSubmit({preventDefault: jest.fn()});
+
+ // Ensure onSubmit is called with expected arguments
+ expect(mockOnSubmit).toHaveBeenCalledWith([{name: "file.py"}], undefined, false, "file.py");
+ });
+
+ it("should not call onSubmit prop when extensions don't match and user cancels", () => {
+ // Mock window.confirm to return false
+ window.confirm = jest.fn(() => false);
+
+ // Mock setState method
+ wrapper.setState({
+ newFiles: [{name: "file1.py"}],
+ renameTo: "file2.txt",
+ });
+
+ // Simulate form submission
+ wrapper.instance().onSubmit({preventDefault: jest.fn()});
+
+ // Ensure onSubmit is not called
+ expect(mockOnSubmit).not.toHaveBeenCalled();
+ });
+
+ it("should call onSubmit prop with correct arguments when extensions don't match and user confirms", () => {
+ // Mock window.confirm to return true
+ window.confirm = jest.fn(() => true);
+
+ // Mock setState method
+ wrapper.setState({
+ newFiles: [{name: "file1.py"}],
+ renameTo: "file2.txt",
+ });
+
+ // Simulate form submission
+ wrapper.instance().onSubmit({preventDefault: jest.fn()});
+
+ // Ensure onSubmit is called with expected arguments
+ expect(mockOnSubmit).toHaveBeenCalledWith(
+ [{name: "file1.py"}],
+ undefined,
+ false,
+ "file2.txt"
+ );
+ });
+ });
 });

config/locales/views/modals/en.yml

@@ -2,4 +2,7 @@
 en:
  modals:
  file_upload:
+ rename_warning: |
+ Changing the file extension may render the file unusable.
+ Are you sure you want to proceed?
  unzip: unzip all zip files in place