feat(2794): ticket account permission selection #11582
Closed
+216
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…complete, we plan to start writing tests next week
…now fixed And was clearing the selected accounts of the edit all accounts flow, and removing accounts was buggy if all permitted were removed before adding a new permitted account, all this is fixed in this commit
…hen this component is used in the context of connecting more accounts
…scription telling the user to select an account when there is none to select
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
… has occured, this feature is only for when feature flag is on
EtherWizard33
added
No QA Needed
EtherWizard33
added
DO-NOT-MERGE
|
…can do, for example he can add and remove in the same click of the update button
|
Cal-L
reviewed
Oct 8, 2024
| ensByAccountAddress={ensByAccountAddress} | ||
| selectedAddresses={selectedAddresses} | ||
| selectedAddresses={effectiveSelectedAddresses} |
There was a problem hiding this comment.
Refs are probably not needed here. This value just needs to be selectedAddresses with the default permitted accounts and set at the same time as navigation if needed.
|
closing this PR since it is now replaced by #11748 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to edit account permissions for in app browser dapps.
Related issues
Contributes to solve issue: https:/MetaMask/MetaMask-planning/issues/2796
Manual testing steps
I have added screenshot below to see how it looks.
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist