Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2794): account edit permission, permission list initialization, edit, and submit #11748

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(2794): account edit permission, permission list initialization, edit, and submit #11748

wants to merge 9 commits into from
+196 −50

Conversation

EtherWizard33
Copy link
Contributor

Description

This PR adds the ability to edit account permissions for in app browser dapps.

Related issues

Contributes to solve issue: https:/MetaMask/MetaMask-planning/issues/2796

Manual testing steps

I have added screenshot below to see how it looks.

  1. Go to the in-app brower on the mobile wallet, connect to a dapp like uniswap
  2. once connected click to top right icon to open the bottom sheet and start editing
  3. examples in screenshots below

Screenshots/Recordings

Add 1 account Remove 1 account
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM
Connect all Disconnect all
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM
Add many Remove many
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33
feat: add the ability to make multiple edit (permissions (add/remove)…
594dd04 
… in one submit
@EtherWizard33
chore: exclude this file from stat converage from now until we circle…
2c7ae15 
… back are feature complete, feature flag removed, dead code removed, and ready to write new tests
@EtherWizard33
feat: add the ability to hide the disconnect all button when necessar…
923ba5c 
…y, this is the case where the user is on the connectMore screen
@EtherWizard33
feat: add the ability to show something relevant when no accounts dis…
4b840db 
…playing, and hide irrelevant text or select all checkbox
@EtherWizard33
style: lint
60dd6a9
@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33
feat: add the ability to navigate back to the permission summary rath…
e5fa0f8 
…er than closing the bottom sheet.

On initial connect, clicking the confirm button navs back to summary without submiting, the summary has a button to submit. On connected flow, in this case it submits before naviging back to summary, a toast is also shown as usual.
@EtherWizard33
style: lint
b224569
@EtherWizard33
fix: the initialization of the list when its used in the connect more…
06d6a85 
… scenario
@EtherWizard33 EtherWizard33 marked this pull request as ready for review October 11, 2024 18:14
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner October 11, 2024 18:14
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1a04123
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ae2290ca-e575-4aff-af4b-2ad60d8648b6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@EtherWizard33 EtherWizard33 mentioned this pull request Oct 11, 2024
Closed
7 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EtherWizard33