Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1702): update onboarding settings UI #11723

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

Description

This is a follow up to this pull request. Updating the UI according to feedback as well as copy @yanrong-chen @hesterbruikman

Screenshot 2024-10-09 at 11 16 10 AM
Screenshot 2024-10-09 at 11 16 25 AM
Screenshot 2024-10-09 at 11 16 41 AM

Related issues

Fixes:
Feature: #1702

Manual testing steps

  1. Fresh install application
  2. Create/import new wallet
  3. Success screen will appear with the title "Your Wallet is ready" and below the title and description, click on the text that says "Manage default settings"
  4. View the changes in within the Default Settings Screen
  5. Click on Assets and scroll down to view no copy for Batch Transactions

Screenshots/Recordings

Default Settings Screen

Before After
Simulator Screenshot - iPhone 16 Pro Max - 2024-10-09 at 15 57 48 Simulator Screenshot - iPhone 16 Pro Max - 2024-10-09 at 15 58 07

Manage Default Settings

Before After
Simulator Screenshot - iPhone 16 Pro Max - 2024-10-09 at 15 58 18 Simulator Screenshot - iPhone 16 Pro Max - 2024-10-09 at 15 58 29

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 63df048
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/394a04ad-1c50-46c3-8b0c-ba943f06049d

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2b50d31
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf5585fa-79e1-4f5f-a11d-d54bbbbaeb00

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant