-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing parts in documentation #28
Labels
documentation 📚
Improvements or additions to documentation
Comments
Hi, I am glad to see this checklist! Here are some notes:
I remain at your disposal for any further questions 😄 |
hbaniecki
added a commit
that referenced
this issue
Oct 24, 2019
[JOSS submission review](openjournals/joss-reviews#1798) [modelStudio issue](#28)
Thanks, this resolves my questions/concerns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I am one of the reviewers for your JOSS submission. I thought I'd put the things I miss in the documentation and the corresponding review checklist items here:
glmnet
for which it requiresgcc-fortran
(which I had to install using my package manager). First I am wondering why it knew that it had to install glmnet - it is not mentioned in this libraries DESCRIPTION (I assume it is a dependency of one of the other packages?) And I am also not sure if it is required that your README mentions that one might need to installgcc-fortran
(because it is not directly used by your package). Just wanted to let you know that this might be an issue :)The text was updated successfully, but these errors were encountered: