-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: modelStudio: Interactive Studio with Explanations for ML Predictive Models #1798
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @acolum, @expectopatronum it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https:/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Great! I am aware that i need to fix paper.bib file to properly code references. I will probably shorten the example. Then Figure 1 should fit one page earlier (same with Figure 2). |
Everything in the software and documentation looks good, but in the paper, there's some spelling, grammar, and citation errors. |
@whedon generate pdf |
|
@whedon generate pdf |
|
The references and citations look great, but I'm still noticing a few spelling errors in the first paragraph under "Introduction" and the paragraph under "Conclusions." |
Yes, I also found several typos / missing articles. I marked them in the PDF: 10.21105.joss.01798_typos.pdf |
@whedon generate pdf |
|
@whedon generate pdf |
|
@whedon generate pdf |
|
Hopefully it is clean now. |
|
@hbaniecki sorry, one last fix I noticed when reviewing: ModelOriented/modelStudio#33 |
@kyleniemeyer np. I merged. |
@whedon generate pdf |
|
@whedon accept |
|
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#1090 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1090, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
Congrats @hbaniecki on your article's publication in JOSS! Many thanks to @acolum and @expectopatronum for reviewing this, and @terrytangyuan for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
wow even after so many reviews i can see a typo. @kyleniemeyer is it possible to fix the paper after the publication? |
Oh no! Um, I think so. Can you fix the source file and let us know? (@arfon?) |
I feel ashamed but hope that it can be updated. Fixed |
No problem. Paper updated based on the latest |
Submitting author: @hbaniecki (Hubert Baniecki)
Repository: https:/ModelOriented/modelStudio
Version: v0.1.9
Editor: @terrytangyuan
Reviewer: @acolum, @expectopatronum
Archive: 10.5281/zenodo.3527770
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@acolum & @expectopatronum, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @terrytangyuan know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @acolum
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @expectopatronum
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: