Drop support for Python 3.7 and Pyspark 2.x and remove vendored dependency on six #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpgmaas
changed the title
fpgmaas
changed the title
fpgmaas
force-pushed
the
fix/six-and-update
branch
from
577e846
to
d5f4c01
Compare
…dendencies update pytest describe add flexible terminal string formatter start swapping in default formats start phasing out underline_cells wip wip demonstrate how custom formatting can be injected via pytest fixtures wip make sure format_string works with no formats add new custom formatter to readme bump to v0.10.0 New Chispa interface (MrPowers#94) * add formats to dataframe comparer * add new chispa interface lock run tests for multiple python versions small fix add runs-on argument fix reset ci
fpgmaas
force-pushed
the
fix/six-and-update
branch
from
d5f4c01
to
4b7d453
Compare
|
@MrPowers I think this one is ready for review; is it time to drop support for Python |
fpgmaas
changed the title
fpgmaas
changed the title
|
@SemyonSinchenko Do you have time to review this one by any chance? I based a few other PR's on top of this one. (#81 and #106), so if this is merged I can rebase those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
six..python_versionto.gitgnore.For removing the dependency on
six, I simply replacedsix.moves.zip_longestwithitertools.zip_longestas suggested by @MrPowers. I however did not test if this changes existing functionality, I assume that is already covered by the unit tests? Those ran uccessfully.See also #78