Add unit tests for multiple python versions to CI stage #81
Conversation
|
@fpgmaas - really sorry for never responding here. Should we have merged this one? |
|
@MrPowers No worries; I think that is my own doing, since you pointed out in another PR that you did not want to drop support for Python 3.7 just yet, and then life got in the way and I didn't get around to updating it. I'll take a look at it again somewhere this week and try to modify & reopen PR's that could still be useful. |
|
@fpgmaas - yea, thanks for understanding. We're actually dropping support for PySpark 2 on quinn, so now is probably a good time to make these changes for chispa as well. Let's brainstorm the next steps for this project! |
fpgmaas
force-pushed
the
feature/ci
branch
2 times, most recently
from
e201b99
to
576a2a7
Compare
small fix add runs-on argument remove dependency on six, drop support for python 3.7, update dev depdendencies update pytest describe merge successful small fix fix docs ci check update mkdocs dependencies update poetry in cicd update lock
|
@SemyonSinchenko just a heads up that this is an old PR so it won't show up at the top of open PR's. If you have time, could you review? No hurry! :) |
I think I resolved them! |
This PR builds upon this PR. When that is merged I can update this branch to better reflect the changes in "Files changed".
Related issue: #82
This PR adds testing against multiple Python versions, updates some of the mkdocs dependencies, and changes the trigger of the CI checks to run on each pull request and on each commit to master (i.e. merging a PR). For an example run, see here, or approve the workflow run on this PR.
This also adds a check for the
poetry.lockfile; to prevent issues like #107I think this can be helpful, let me know what you think of the proposal!