Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to production #27

Merged
merged 63 commits into from
Jun 6, 2022
Merged

Staging to production #27

merged 63 commits into from
Jun 6, 2022

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Jun 2, 2022

I think this is good time to sync production with staging (and then we can start looking into production asset problem)

danielfdsilva and others added 30 commits March 23, 2022 11:05
Documentation and delta-ui update
Add mapbox style to environment variable
Explain more about how thematic areas/datasets/discovery are related to
Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some "Lorem Ipsum" going around. This was why it wasn't deployed last time.
If we're ok with this now (I think we'll iterate quickly enough and it is better than the current broken page), them merge! :shipit:

@hanbyul-here
Copy link
Collaborator Author

I would like to get a clear understanding about There is still some "Lorem Ipsum" going around. This was why it wasn't deployed last time. Did we intentionally take the build down because there was meaningless content?

@danielfdsilva
Copy link
Collaborator

@hanbyul-here indeed. We had deployed to the production url, but since part of the data was still dummy, the build was taken down and replaced with a coming soon page. (which was apparently overwritten)

@hanbyul-here
Copy link
Collaborator Author

Ah I see.Huh I wonder how it was overwritten? I think having a dummy data is better than the current broken state of the app.

@danielfdsilva
Copy link
Collaborator

Not sure when it happened, but I agree that we should merge. Approving

@hanbyul-here hanbyul-here merged commit ca99c42 into main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants