This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Fix H5FileImageWriter Callback #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Don't delete h5 files during compute metrics (no test).
|
@jonasteuwen Can you please review this PR? It's been here for some time. |
|
@AjeyPaiK I think current dlup version should make this very easy on you. You can use |
|
@jonasteuwen Now, I think this is good to go! |
# Conflicts: # ahcore/callbacks.py
|
Issue addressed in #22 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes {#16}
limit_bounds#16 was reported, upstream dlup was modified to return the scaled bounds. While writing H5 files, we now directly call this function to infer the scaled size of the WSI.