Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

The H5 Writer callback doesn't take into account offset induced by limit_bounds #16

Closed
AjeyPaiK opened this issue Nov 13, 2023 · 1 comment
Closed

The H5 Writer callback doesn't take into account offset induced by limit_bounds #16

AjeyPaiK opened this issue Nov 13, 2023 · 1 comment
Assignees
@AjeyPaiK
Labels
bug Something isn't working

Comments

@AjeyPaiK
Copy link
Member

In ahcore, we use limit_bounds on slides which do not have any rois specified for it. This is especially helpful when we have whole slide images (WSI) which have a lot of redundant (unwanted background) tiles.

If we use limit_bounds, an offset is required to properly demarcate the region where we can find the tissue specimen on the WSI.

However, the H5FileImageWriter doesn't account for this currently and it breaks while writing h5 files.
@AjeyPaiK AjeyPaiK added the bug Something isn't working label Nov 13, 2023
@AjeyPaiK AjeyPaiK self-assigned this Nov 13, 2023
AjeyPaiK added a commit that referenced this issue Nov 13, 2023
@AjeyPaiK
Fixes{#16}
616feb6
@AjeyPaiK AjeyPaiK mentioned this issue Nov 14, 2023
Closed
@jonasteuwen
Copy link
Contributor

jonasteuwen commented Nov 25, 2023 •
edited
Loading

See NKI-AI/dlup#201 for a streamlined way to address this

@AjeyPaiK AjeyPaiK mentioned this issue Dec 19, 2023
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AjeyPaiK AjeyPaiK

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonasteuwen @AjeyPaiK