Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logic of limit_bounds together with rois #201

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Improve logic of limit_bounds together with rois #201

merged 2 commits into from
Nov 27, 2023

Conversation

jonasteuwen
Copy link
Contributor

  • Fixes and closes Allow selection of annotation sorting #195, the sorting setting can now be set in the constructor. By default the previous values are used
  • limit_bounds and rois are not anymore mutually exclusive in TiledWsiDataset. If limit_bounds=True and rois is set the limit bounds are ignored. Additionally added a function get_scaled_slide_bounds to conveniently obtain those values
  • Improve the docstrings

jonasteuwen added a commit to NKI-AI/ahcore that referenced this pull request Nov 25, 2023
@jonasteuwen
limit_bounds can always be set to True with changes in NKI-AI/dlup#201
ca83164
@jonasteuwen jonasteuwen added this to the v0.3.33 milestone Nov 25, 2023
This was referenced Nov 25, 2023
Merged
Closed
Closed
EricMarcus-ai
EricMarcus-ai approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@EricMarcus-ai EricMarcus-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a small test run on training and inference on ahcore using the updated version without issues. LGTM

@jonasteuwen jonasteuwen merged commit 5415327 into main Nov 27, 2023
8 checks passed
@jonasteuwen jonasteuwen deleted the feature/improve-handling-of-slide-bounds branch November 27, 2023 17:54
@jonasteuwen jonasteuwen restored the feature/improve-handling-of-slide-bounds branch November 28, 2023 00:06
@jonasteuwen jonasteuwen deleted the feature/improve-handling-of-slide-bounds branch May 25, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricMarcus-ai EricMarcus-ai EricMarcus-ai approved these changes

@AjeyPaiK AjeyPaiK Awaiting requested review from AjeyPaiK

@BPdeRooij BPdeRooij Awaiting requested review from BPdeRooij

@sinberlin2 sinberlin2 Awaiting requested review from sinberlin2

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
v0.3.33
Development

Successfully merging this pull request may close these issues.

Allow selection of annotation sorting
2 participants
@jonasteuwen @EricMarcus-ai